Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: chrome/android/java/res/layout/four_button_menu_item.xml

Issue 377083002: Update menu look and feel on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased and removed binary pngs Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/res/layout/menu_item.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/four_button_menu_item.xml
diff --git a/chrome/android/java/res/layout/four_button_menu_item.xml b/chrome/android/java/res/layout/four_button_menu_item.xml
index 1e47144771d799245711f28e894a50aec9315798..d0296f62b6f40de8b76bb833fc3c741848fa769a 100644
--- a/chrome/android/java/res/layout/four_button_menu_item.xml
+++ b/chrome/android/java/res/layout/four_button_menu_item.xml
@@ -6,54 +6,41 @@
-->
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
- android:layout_height="wrap_content"
+ android:layout_height="?android:attr/listPreferredItemHeightSmall"
android:layout_gravity="top|start"
android:orientation="horizontal">
<ImageButton
android:id="@+id/button_one"
- android:layout_width="wrap_content"
+ android:layout_width="56dp"
android:layout_height="match_parent"
- android:layout_weight="1"
+ android:paddingEnd="8dp"
android:background="?android:attr/listChoiceBackgroundIndicator"
android:scaleType="center" />
- <View
- android:layout_width="1dp"
- android:layout_height="?android:attr/listPreferredItemHeightSmall"
- android:background="?android:attr/listDivider" />
-
<ImageButton
android:id="@+id/button_two"
- android:layout_width="wrap_content"
+ android:layout_width="64dp"
android:layout_height="match_parent"
- android:layout_weight="1"
+ android:paddingStart="8dp"
+ android:paddingEnd="8dp"
android:background="?android:attr/listChoiceBackgroundIndicator"
android:scaleType="center" />
- <View
- android:layout_width="1dp"
- android:layout_height="?android:attr/listPreferredItemHeightSmall"
- android:background="?android:attr/listDivider" />
-
<ImageButton
android:id="@+id/button_three"
- android:layout_width="wrap_content"
+ android:layout_width="64dp"
android:layout_height="match_parent"
- android:layout_weight="1"
+ android:paddingStart="8dp"
+ android:paddingEnd="8dp"
android:background="?android:attr/listChoiceBackgroundIndicator"
android:scaleType="center" />
-
- <View
- android:layout_width="1dp"
- android:layout_height="?android:attr/listPreferredItemHeightSmall"
- android:background="?android:attr/listDivider" />
<ImageButton
android:id="@+id/button_four"
- android:layout_width="wrap_content"
+ android:layout_width="56dp"
android:layout_height="match_parent"
- android:layout_weight="1"
+ android:paddingStart="8dp"
android:background="?android:attr/listChoiceBackgroundIndicator"
android:scaleType="center" />
« no previous file with comments | « no previous file | chrome/android/java/res/layout/menu_item.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698