chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java - Issue 377083002: Update menu look and feel on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java

Issue 377083002: Update menu look and feel on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java

index 37f6f97f54f32eb4b2390c63d5c0c78749d942ff..3819c1f5bba4255916c6a64b3ce595c84f89cc03 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java

@@ -174,7 +174,6 @@ class AppMenuAdapter extends BaseAdapter {

holder = new TitleButtonMenuItemViewHolder();

convertView = mInflater.inflate(R.layout.title_button_menu_item, null);

holder.title = (TextView) convertView.findViewById(R.id.title);

- holder.divider = convertView.findViewById(R.id.divider);

holder.button = (ImageButton) convertView.findViewById(R.id.button);

convertView.setTag(holder);

} else {

@@ -192,11 +191,9 @@ class AppMenuAdapter extends BaseAdapter {

});

if (item.getSubMenu().getItem(1).getIcon() != null) {

holder.button.setVisibility(View.VISIBLE);

- holder.divider.setVisibility(View.VISIBLE);

setupImageButton(holder.button, item.getSubMenu().getItem(1));

} else {

holder.button.setVisibility(View.GONE);

- holder.divider.setVisibility(View.GONE);

}

convertView.setFocusable(false);

convertView.setEnabled(false);

@@ -245,7 +242,6 @@ class AppMenuAdapter extends BaseAdapter {

static class TitleButtonMenuItemViewHolder {

public TextView title;

- public View divider;

public ImageButton button;

}