Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 377015: Theme the text of the download item so it's readable with dark themes.... (Closed)

Created:
11 years, 1 month ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
Nico, Nicholas Jitkoff
CC:
chromium-reviews_googlegroups.com, John Grabowski, Paul Godavari, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Theme the text of the download item so it's readable with dark themes. BUG=http://crbug.com/21559 TEST=as in bug

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M chrome/browser/cocoa/download_item_controller.mm View 5 chunks +23 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
11 years, 1 month ago (2009-11-06 21:19:01 UTC) #1
Nico
LGTM if the UI folks are ok with us looking different from win / linux ...
11 years, 1 month ago (2009-11-06 23:29:36 UTC) #2
Nico
http://codereview.chromium.org/377015/diff/1/2 File chrome/browser/cocoa/download_item_controller.mm (right): http://codereview.chromium.org/377015/diff/1/2#newcode90 Line 90: object:nil]; Oh, and you need to removeObserver:self in ...
11 years, 1 month ago (2009-11-08 09:37:14 UTC) #3
Avi (use Gerrit)
UX comment? Just theming text to make it readable.
11 years, 1 month ago (2009-11-08 17:44:31 UTC) #4
Avi (use Gerrit)
http://codereview.chromium.org/377015/diff/1/2 File chrome/browser/cocoa/download_item_controller.mm (right): http://codereview.chromium.org/377015/diff/1/2#newcode90 Line 90: object:nil]; On 2009/11/08 09:37:14, Nico wrote: > Oh, ...
11 years, 1 month ago (2009-11-08 17:45:26 UTC) #5
Avi (use Gerrit)
11 years, 1 month ago (2009-11-09 19:49:55 UTC) #6
Cole says it's OK for now so we can see the warning. If we want to do some
lightening of the background that'd be great.

Powered by Google App Engine
This is Rietveld 408576698