Theme the text of the download item so it's readable with dark themes....

chrome/browser/cocoa/download_item_controller.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/download_item_controller.h"
 
 #include "app/gfx/text_elider.h"
 #include "app/l10n_util_mac.h"
 #include "app/resource_bundle.h"
 #include "base/mac_util.h"
 #include "base/sys_string_conversions.h"
 #import "chrome/browser/cocoa/download_item_cell.h"
 #include "chrome/browser/cocoa/download_item_mac.h"
 #import "chrome/browser/cocoa/download_shelf_controller.h"
 #import "chrome/browser/cocoa/ui_localizer.h"
 #include "chrome/browser/download/download_item_model.h"
 #include "chrome/browser/download/download_shelf.h"
 #include "chrome/browser/download/download_util.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
+#import "third_party/GTM/AppKit/GTMTheme.h"
 #include "third_party/GTM/AppKit/GTMUILocalizerAndLayoutTweaker.h"
 
 static const int kTextWidth = 140;            // Pixels
 
 namespace {
 
 // Helper to widen a view.
 void WidenView(NSView* view, CGFloat widthChange) {
   // If it is an NSBox, the autoresize of the contentView is the issue.
   NSView* contentView = view;
@@ skipping 27 matching lines @@
   using DownloadShelfContextMenu::ItemIsChecked;
   using DownloadShelfContextMenu::IsItemCommandEnabled;
 
   using DownloadShelfContextMenu::SHOW_IN_FOLDER;
   using DownloadShelfContextMenu::OPEN_WHEN_COMPLETE;
   using DownloadShelfContextMenu::ALWAYS_OPEN_TYPE;
   using DownloadShelfContextMenu::CANCEL;
 };
 
 @interface DownloadItemController (Private)
+- (void)themeDidChangeNotification:(NSNotification*)aNotification;
+- (void)updateTheme:(GTMTheme*)theme;
 - (void)setState:(DownoadItemState)state;
 @end
 
 // Implementation of DownloadItemController
 
 @implementation DownloadItemController
 
 - (id)initWithModel:(BaseDownloadItemModel*)downloadModel
               shelf:(DownloadShelfController*)shelf {
   if ((self = [super initWithNibName:@"DownloadItem"
                               bundle:mac_util::MainAppBundle()])) {
     // Must be called before [self view], so that bridge_ is set in awakeFromNib
     bridge_.reset(new DownloadItemMac(downloadModel, self));
     menuBridge_.reset(new DownloadShelfContextMenuMac(downloadModel));
 
+    NSNotificationCenter* defaultCenter = [NSNotificationCenter defaultCenter];
+    [defaultCenter addObserver:self
+                      selector:@selector(themeDidChangeNotification:)
+                          name:kGTMThemeDidChangeNotification
+                        object:nil];

[Nico, 2009/11/08 09:37:14]

Oh, and you need to removeObserver:self in dealloc. That's important.

[Avi (use Gerrit), 2009/11/08 17:45:26]

Um, I already _do_. Well, _I_ don't, but it's already there so it doesn't need
to be added. Look at line 100.

+
     shelf_ = shelf;
     state_ = kNormal;
     creationTime_ = base::Time::Now();
   }
   return self;
 }
 
 - (void)dealloc {
   [[NSNotificationCenter defaultCenter] removeObserver:self];
   [[self view] removeFromSuperview];
@@ skipping 71 matching lines @@
 - (void)setIcon:(NSImage*)icon {
   [cell_ setImage:icon];
 }
 
 - (void)remove {
   // We are deleted after this!
   [shelf_ remove:self];
 }
 
 - (void)updateVisibility:(id)sender {
+  if ([[self view] window])
+    [self updateTheme:[[self view] gtm_theme]];
+
   // TODO(thakis): Make this prettier, by fading the items out or overlaying
   // the partial visible one with a horizontal alpha gradient -- crbug.com/17830
   NSView* view = [self view];
   NSRect containerFrame = [[view superview] frame];
   [view setHidden:(NSMaxX([view frame]) > NSWidth(containerFrame))];
 }
 
 - (IBAction)handleButtonClick:(id)sender {
   if ([cell_ isButtonPartPressed]) {
     DownloadItem* download = bridge_->download_model()->download();
@@ skipping 35 matching lines @@
     [progressView_ setHidden:NO];
     [dangerousDownloadView_ setHidden:YES];
   } else {
     DCHECK_EQ(kDangerous, state_);
     [progressView_ setHidden:YES];
     [dangerousDownloadView_ setHidden:NO];
   }
   [shelf_ layoutItems];
 }
 
+- (void)themeDidChangeNotification:(NSNotification*)aNotification {
+  GTMTheme* theme = [aNotification object];
+  [self updateTheme:theme];
+}
+
+- (void)updateTheme:(GTMTheme*)theme {
+  NSColor* color = [theme textColorForStyle:GTMThemeStyleTabBarSelected
+                                      state:GTMThemeStateActiveWindow];
+  [dangerousDownloadLabel_ setTextColor:color];
+}
+
 - (IBAction)saveDownload:(id)sender {
   // The user has confirmed a dangerous download.  We record how quickly the
   // user did this to detect whether we're being clickjacked.
   UMA_HISTOGRAM_LONG_TIMES("clickjacking.save_download",
                            base::Time::Now() - creationTime_);
   // This will change the state and notify us.
   bridge_->download_model()->download()->manager()->DangerousDownloadValidated(
       bridge_->download_model()->download());
 }
 
@@ skipping 48 matching lines @@
 
 - (IBAction)handleReveal:(id)sender {
   menuBridge_->ExecuteItemCommand(DownloadShelfContextMenuMac::SHOW_IN_FOLDER);
 }
 
 - (IBAction)handleCancel:(id)sender {
   menuBridge_->ExecuteItemCommand(DownloadShelfContextMenuMac::CANCEL);
 }
 
 @end