src/effects/SkLightingImageFilter.cpp - Issue 376953003: Clean up SkImageFilter constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkLightingImageFilter.cpp

Issue 376953003: Clean up SkImageFilter constructors. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix deserializing constructor for SkRectShaderImageFilter Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkLightingImageFilter.cpp

diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp

index c0c605ca040b88216ccd3b4dbdf7785aa74cb04f..efe6c9176ceb602a5365500156fd59d97b0fe640 100644

--- a/src/effects/SkLightingImageFilter.cpp

+++ b/src/effects/SkLightingImageFilter.cpp

@@ -830,7 +830,7 @@ void SkLight::flattenLight(SkWriteBuffer& buffer) const {

///////////////////////////////////////////////////////////////////////////////

SkLightingImageFilter::SkLightingImageFilter(SkLight* light, SkScalar surfaceScale, SkImageFilter* input, const CropRect* cropRect)

reed1 2014/07/08 15:15:24 nit: 100 col

Stephen White 2014/07/08 15:33:30 Fixed.

- : INHERITED(input, cropRect),

+ : INHERITED(1, &input, cropRect),

fLight(light),

fSurfaceScale(SkScalarDiv(surfaceScale, SkIntToScalar(255)))

{