Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 37683004: GTTF: Make EmbeddedTestServer always use its own thread for IO (Closed)

Created:
7 years, 2 months ago by Paweł Hajdan Jr.
Modified:
7 years, 1 month ago
Reviewers:
jam, Ryan Hamilton
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, tfarina, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

GTTF: Make EmbeddedTestServer always use its own thread for IO Otherwise we likely end up blocking the browser's IO thread, especially with big responses that don't fit in the kernel buffer. This blocks EmbeddedTestServer's IO thread, and if it's also the browser's IO thread the browser can't consume the response resulting in a hang. BUG=310713 R=jam@chromium.org, rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231075

Patch Set 1 #

Patch Set 2 : trybots #

Patch Set 3 : trybots #

Patch Set 4 : trybots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -58 lines) Patch
M chrome/browser/chromeos/contacts/gdata_contacts_service_unittest.cc View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_apitest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/google_apis/base_requests_server_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/google_apis/drive_api_requests_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_requests_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_fetcher_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/public/test/browser_test_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/browser_test_base.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server.h View 3 chunks +5 lines, -6 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server.cc View 9 chunks +16 lines, -12 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
7 years, 2 months ago (2013-10-23 22:58:15 UTC) #1
jam
redirecting to rch who reviewed some of the earlier changes
7 years, 2 months ago (2013-10-23 23:24:14 UTC) #2
Ryan Hamilton
net/ lgtm (but I'm not a chrome/ or content/ owner)
7 years, 2 months ago (2013-10-24 00:31:40 UTC) #3
jam
lgtm
7 years, 2 months ago (2013-10-24 00:41:39 UTC) #4
Paweł Hajdan Jr.
7 years, 1 month ago (2013-10-25 19:17:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r231075 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698