Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1764)

Unified Diff: content/public/test/browser_test_base.cc

Issue 37683004: GTTF: Make EmbeddedTestServer always use its own thread for IO (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: trybots Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/browser_test_base.h ('k') | net/test/embedded_test_server/embedded_test_server.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/browser_test_base.cc
diff --git a/content/public/test/browser_test_base.cc b/content/public/test/browser_test_base.cc
index 5fed0cc442c9fb8956d943c237bc1d5ed34c0c8c..c0617c44d2845a56e1da038b42930368f5525588 100644
--- a/content/public/test/browser_test_base.cc
+++ b/content/public/test/browser_test_base.cc
@@ -114,8 +114,7 @@ class LocalHostResolverProc : public net::HostResolverProc {
extern int BrowserMain(const MainFunctionParams&);
BrowserTestBase::BrowserTestBase()
- : embedded_test_server_io_thread_("EmbeddedTestServer io thread"),
- allow_test_contexts_(true),
+ : allow_test_contexts_(true),
allow_osmesa_(true) {
#if defined(OS_MACOSX)
base::mac::SetOverrideAmIBundled(true);
@@ -126,15 +125,7 @@ BrowserTestBase::BrowserTestBase()
handle_sigterm_ = true;
#endif
- // Create a separate thread for the test server to run on. It's tempting to
- // use actual browser threads, but that doesn't work for cases where the test
- // server needs to be started before the browser, for example when the server
- // URL should be passed in command-line parameters.
- base::Thread::Options thread_options;
- thread_options.message_loop_type = base::MessageLoop::TYPE_IO;
- CHECK(embedded_test_server_io_thread_.StartWithOptions(thread_options));
- embedded_test_server_.reset(new net::test_server::EmbeddedTestServer(
- embedded_test_server_io_thread_.message_loop_proxy()));
+ embedded_test_server_.reset(new net::test_server::EmbeddedTestServer);
}
BrowserTestBase::~BrowserTestBase() {
« no previous file with comments | « content/public/test/browser_test_base.h ('k') | net/test/embedded_test_server/embedded_test_server.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698