chrome/browser/history/history_backend.h - Issue 376703007: Change HistoryService::ScheduleAutocomplete interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_backend.h

Issue 376703007: Change HistoryService::ScheduleAutocomplete interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/history/history_backend.h

diff --git a/chrome/browser/history/history_backend.h b/chrome/browser/history/history_backend.h

index 9e24f06c8226ca75f856db89e23731e07486e305..cb1edb839ffcd1e159e8288a0cd9acdf1fadafd8 100644

--- a/chrome/browser/history/history_backend.h

+++ b/chrome/browser/history/history_backend.h

@@ -159,11 +159,12 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,

// Querying ------------------------------------------------------------------

- // ScheduleAutocomplete() never frees |provider| (which is globally live).

- // It passes |params| on to the autocomplete system which will eventually

- // free it.

- void ScheduleAutocomplete(HistoryURLProvider* provider,

- HistoryURLProviderParams* params);

+ // Run the |callback| on the History thread.

+ // history_url_provider.h has the temporal ordering for

+ // the call sequence.

+ // |callback| should handle the NULL database case.

+ void ScheduleAutocomplete(const base::Callback<

+ void(history::HistoryBackend*, history::URLDatabase*)>& callback);

void IterateURLs(

const scoped_refptr<visitedlink::VisitedLinkDelegate::URLEnumerator>&

« no previous file with comments | « chrome/browser/autocomplete/history_url_provider.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »