chrome/browser/history/history_backend.cc - Issue 376703007: Change HistoryService::ScheduleAutocomplete interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_backend.cc

Issue 376703007: Change HistoryService::ScheduleAutocomplete interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/history/history_backend.cc

diff --git a/chrome/browser/history/history_backend.cc b/chrome/browser/history/history_backend.cc

index c72f8c01d969086ed87725711096763af815f977..bdb55b34b3b654d4afdbda714ab4719c6094b9a7 100644

--- a/chrome/browser/history/history_backend.cc

+++ b/chrome/browser/history/history_backend.cc

@@ -23,7 +23,6 @@

#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

#include "base/time/time.h"

-#include "chrome/browser/autocomplete/history_url_provider.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/favicon/favicon_changed_details.h"

#include "chrome/browser/history/download_row.h"

@@ -1464,10 +1463,9 @@ void HistoryBackend::GetRedirectsToSpecificVisit(

}

-void HistoryBackend::ScheduleAutocomplete(HistoryURLProvider* provider,

- HistoryURLProviderParams* params) {

- // ExecuteWithDB should handle the NULL database case.

- provider->ExecuteWithDB(this, db_.get(), params);

+void HistoryBackend::ScheduleAutocomplete(const base::Callback<

+ void(history::HistoryBackend*, history::URLDatabase*)>& callback) {

+ callback.Run(this, db_.get());

}

void HistoryBackend::DeleteFTSIndexDatabases() {

« no previous file with comments | « chrome/browser/history/history_backend.h ('k') | chrome/browser/history/history_service.h » ('j') | no next file with comments »