Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: test/ios/extension/ActionExtension/ActionViewController.m

Issue 376603002: This CL adds support for extension in GYP. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: comment corrections Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/ios/extension/ActionExtension/ActionViewController.m
diff --git a/test/ios/extension/ActionExtension/ActionViewController.m b/test/ios/extension/ActionExtension/ActionViewController.m
new file mode 100644
index 0000000000000000000000000000000000000000..801dfde030620a155e9b401f0a459d0f4b36b79d
--- /dev/null
+++ b/test/ios/extension/ActionExtension/ActionViewController.m
@@ -0,0 +1,41 @@
+// Copyright (c) 2014 Google Inc. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ActionViewController.h"
+#import <MobileCoreServices/MobileCoreServices.h>
+
+@interface ActionViewController ()
+
+
pkl (ping after 24h if needed) 2014/07/09 08:07:50 Just 1 blank line. And is it really necessary to h
olivierrobin 2014/07/09 12:46:27 Done.
+@end
+
+@implementation ActionViewController
+
+- (instancetype)initWithNibName:(NSString *)nibNameOrNil
pkl (ping after 24h if needed) 2014/07/09 08:07:50 No space before *. Here and below.
olivierrobin 2014/07/09 12:46:27 Done.
+ bundle:(NSBundle *)nibBundleOrNil {
+ self = [super initWithNibName:nibNameOrNil bundle:nibBundleOrNil];
+ if (self) {
+ // Custom initialization
+ }
+ return self;
pkl (ping after 24h if needed) 2014/07/09 08:07:50 Can't you just get rid of this boilerplate initial
olivierrobin 2014/07/09 12:46:27 Done.
+}
+
+- (void)viewDidLoad {
+ [super viewDidLoad];
+}
+
+- (void)didReceiveMemoryWarning {
+ [super didReceiveMemoryWarning];
+ // Dispose of any resources that can be recreated.
+}
+
+- (IBAction)done {
+ // Return any edited content to the host app.
pkl (ping after 24h if needed) 2014/07/09 08:07:50 indent 2.
olivierrobin 2014/07/09 12:46:27 Done.
+ // This template doesn't do anything, so we just echo the passed in items.
+ [self.extensionContext
+ completeRequestReturningItems:self.extensionContext.inputItems
+ completionHandler:nil];
+}
+
+@end

Powered by Google App Engine
This is Rietveld 408576698