Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: test/ios/extension/ActionExtension/ActionViewController.m

Issue 376603002: This CL adds support for extension in GYP. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: comment corrections Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2014 Google Inc. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #import "ActionViewController.h"
6 #import <MobileCoreServices/MobileCoreServices.h>
7
8 @interface ActionViewController ()
9
10
pkl (ping after 24h if needed) 2014/07/09 08:07:50 Just 1 blank line. And is it really necessary to h
olivierrobin 2014/07/09 12:46:27 Done.
11 @end
12
13 @implementation ActionViewController
14
15 - (instancetype)initWithNibName:(NSString *)nibNameOrNil
pkl (ping after 24h if needed) 2014/07/09 08:07:50 No space before *. Here and below.
olivierrobin 2014/07/09 12:46:27 Done.
16 bundle:(NSBundle *)nibBundleOrNil {
17 self = [super initWithNibName:nibNameOrNil bundle:nibBundleOrNil];
18 if (self) {
19 // Custom initialization
20 }
21 return self;
pkl (ping after 24h if needed) 2014/07/09 08:07:50 Can't you just get rid of this boilerplate initial
olivierrobin 2014/07/09 12:46:27 Done.
22 }
23
24 - (void)viewDidLoad {
25 [super viewDidLoad];
26 }
27
28 - (void)didReceiveMemoryWarning {
29 [super didReceiveMemoryWarning];
30 // Dispose of any resources that can be recreated.
31 }
32
33 - (IBAction)done {
34 // Return any edited content to the host app.
pkl (ping after 24h if needed) 2014/07/09 08:07:50 indent 2.
olivierrobin 2014/07/09 12:46:27 Done.
35 // This template doesn't do anything, so we just echo the passed in items.
36 [self.extensionContext
37 completeRequestReturningItems:self.extensionContext.inputItems
38 completionHandler:nil];
39 }
40
41 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698