Issue 376513002: Remove useless TabDragController::detach_behavior_ and TabDragController::detach_into_browser_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 376513002: Remove useless TabDragController::detach_behavior_ and TabDragController::detach_into_browser_ (Closed)

Created:
6 years, 5 months ago by pkotwicz

Modified:
6 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Remove useless TabDragController::detach_behavior_ and TabDragController::detach_into_browser_ BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282366

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -285 lines)			Patch
M	chrome/browser/ui/browser_tab_strip_model_delegate.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser_tab_strip_model_delegate.cc	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/tabs/tab_strip_model_delegate.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/tabs/test_tab_strip_model_delegate.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/tabs/test_tab_strip_model_delegate.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_drag_controller.h	View	10 chunks	+1 line, -51 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_drag_controller.cc	View	28 chunks	+19 lines, -210 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

pkotwicz

Scott, PTAL This CL is possible as a result of the refactoring in https://codereview.chromium.org/243703003 I ...

6 years, 5 months ago (2014-07-07 00:24:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/376513002/80001

6 years, 5 months ago (2014-07-10 14:18:49 UTC) #4

Message was sent while issue was closed.

Change committed as 282366