Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 243703003: Removes win8_util (Closed)

Created:
6 years, 8 months ago by sky
Modified:
6 years, 8 months ago
Reviewers:
ananta
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jennb, benjhayden+dwatch_chromium.org, tfarina, jam, Dmitry Titov, dcheng, marja+watch_chromium.org, darin-cc_chromium.org, jianli, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Removes win8_util IsSingleWindowMetroMode is always false not that we only use ash. BUG=none TEST=none R=ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264957

Patch Set 1 #

Patch Set 2 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1274 lines) Patch
M chrome/browser/download/download_status_updater_win.cc View 3 chunks +0 lines, -80 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 1 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 5 chunks +1 line, -44 lines 0 comments Download
M chrome/browser/extensions/launch_util.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/net/proxy_service_factory.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/browser/notifications/desktop_notification_service_win.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 4 chunks +10 lines, -47 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc View 3 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_win.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 2 chunks +1 line, -15 lines 0 comments Download
M chrome/browser/ui/panels/panel_manager.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 2 chunks +0 lines, -12 lines 0 comments Download
D chrome/browser/ui/startup/startup_browser_creator_win.h View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/ui/startup/startup_browser_creator_win.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 3 chunks +1 line, -27 lines 0 comments Download
D chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_win.cc View 1 chunk +0 lines, -140 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 7 chunks +3 lines, -47 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 3 chunks +24 lines, -30 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 4 chunks +20 lines, -39 lines 0 comments Download
D chrome/browser/ui/views/hung_renderer_view_win.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/ui/views/hung_renderer_view_win.cc View 1 chunk +0 lines, -171 lines 0 comments Download
M chrome/browser/ui/views/profiles/user_manager_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc View 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_win.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_win.cc View 1 chunk +0 lines, -78 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_icon_win.h View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_icon_win.cc View 2 chunks +0 lines, -50 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_win.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 5 chunks +0 lines, -8 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D win8/util/win8_util.h View 1 chunk +0 lines, -18 lines 0 comments Download
D win8/util/win8_util.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M win8/win8.gyp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sky
6 years, 8 months ago (2014-04-18 21:46:21 UTC) #1
ananta
lgtm
6 years, 8 months ago (2014-04-18 22:00:33 UTC) #2
ananta
lgtm
6 years, 8 months ago (2014-04-18 22:00:42 UTC) #3
ananta
lgtm
6 years, 8 months ago (2014-04-18 22:00:51 UTC) #4
sky
The CQ bit was checked by sky@chromium.org
6 years, 8 months ago (2014-04-20 18:20:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/243703003/20001
6 years, 8 months ago (2014-04-20 18:21:00 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-20 22:29:12 UTC) #7
Message was sent while issue was closed. 
Change committed as 264957

Powered by Google App Engine
This is Rietveld 408576698