Migrate the notification permission to the new common permission classes.

chrome/browser/notifications/desktop_notification_infobar_delegate.h

Index: chrome/browser/notifications/desktop_notification_infobar_delegate.h
diff --git a/chrome/browser/notifications/desktop_notification_infobar_delegate.h b/chrome/browser/notifications/desktop_notification_infobar_delegate.h
new file mode 100644
index 0000000000000000000000000000000000000000..39d3978ae3d23e90bb477c726df0248eb46b74c8
--- /dev/null
+++ b/chrome/browser/notifications/desktop_notification_infobar_delegate.h
@@ -0,0 +1,40 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_NOTIFICATIONS_DESKTOP_NOTIFICATION_INFOBAR_DELEGATE_H_
+#define CHROME_BROWSER_NOTIFICATIONS_DESKTOP_NOTIFICATION_INFOBAR_DELEGATE_H_
+
+#include <string>
+
+#include "chrome/browser/content_settings/permission_infobar_delegate.h"
+
+class DesktopNotificationInfoBarDelegate : public PermissionInfobarDelegate {
+ public:
+  // Creates a Notification permission infobar and delegate and adds the
+  // infobar to |infobar_service|.
+  // Returns the infobar if it was successfully added.

[Peter Beverloo, 2014/07/10 11:29:39]

Nit: continue on the previous line.

[Miguel Garcia, 2014/07/17 17:24:48]

I don't follow this one, if I continue of the previous line I have to break the
statement in the middle since it does not fit in 80 chars

On 2014/07/10 11:29:39, Peter Beverloo wrote:

[Peter Beverloo, 2014/07/18 10:42:37]

Ok. I don't feel strongly about it, generally we treat comments as a single
paragraph.

+  static infobars::InfoBar* Create(InfoBarService* infobar_service,
+                                   PermissionQueueController* controller,
+                                   const PermissionRequestID& id,
+                                   const GURL& requesting_frame,
+                                   const std::string& display_languages);
+ private:
+  DesktopNotificationInfoBarDelegate(PermissionQueueController* controller,
+                                     const PermissionRequestID& id,
+                                     const GURL& requesting_frame,
+                                     int contents_unique_id,
+                                     const std::string& display_languages);
+  virtual ~DesktopNotificationInfoBarDelegate();
+
+  // ConfirmInfoBarDelegate:

[Peter Beverloo, 2014/07/10 11:29:39]

s/ConfirmInfoBarDelegate:/PermissionInfobarDelegate implementation./

I see that PermissionInfobarDelegate inherits from ConfirmInfoBarDelegate, which
actually defines these methods, but referring to a implementation detail of
another class will surely make this comment obsolete at some point in the
future.

[Miguel Garcia, 2014/07/17 17:24:48]

Not sure I fully agree, the whole infobar hierarchy is really well defined and
it's really clear which subclass is responsible of what. However this is a minor
detail so I just changed it.

On 2014/07/10 11:29:39, Peter Beverloo wrote:

+  virtual base::string16 GetMessageText() const OVERRIDE;
+  virtual int GetIconID() const OVERRIDE;
+
+  GURL requesting_frame_;
+  std::string display_languages_;
+
+  DISALLOW_COPY_AND_ASSIGN(DesktopNotificationInfoBarDelegate);
+};
+
+#endif  // CHROME_BROWSER_NOTIFICATIONS_DESKTOP_NOTIFICATION_INFOBAR_DELEGATE_H_