Migrate the notification permission to the new common permission classes.

chrome/browser/content_settings/permission_bubble_request_impl.cc

Index: chrome/browser/content_settings/permission_bubble_request_impl.cc
diff --git a/chrome/browser/content_settings/permission_bubble_request_impl.cc b/chrome/browser/content_settings/permission_bubble_request_impl.cc
index 3767de224fc4decfd91b4e4458a22b0b2f448c1e..0de57d6a9e3bb34407484bdb1364766e3b7a15a5 100644
--- a/chrome/browser/content_settings/permission_bubble_request_impl.cc
+++ b/chrome/browser/content_settings/permission_bubble_request_impl.cc
@@ -33,6 +33,9 @@ PermissionBubbleRequestImpl::~PermissionBubbleRequestImpl() {
 int PermissionBubbleRequestImpl::GetIconID() const {
   int icon_id;
   switch (type_) {
+    case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
+      icon_id = IDR_INFOBAR_DESKTOP_NOTIFICATIONS;
+      break;

[Peter Beverloo, 2014/07/10 11:29:38]

nit: in permission_context_base.cc you add *_NOTIFICATIONS at the end of the
switch, in this file you add the defines at the beginning of the switch.
Consistency (probably in order of the enum's value declarations) would be nice.

[Miguel Garcia, 2014/07/17 17:24:48]

Done.

     case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
       icon_id = IDR_ALLOWED_MIDI_SYSEX;
       break;
@@ -49,6 +52,9 @@ int PermissionBubbleRequestImpl::GetIconID() const {
 base::string16 PermissionBubbleRequestImpl::GetMessageText() const {
   int message_id;
   switch (type_) {
+      case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
+        message_id = IDS_NOTIFICATION_PERMISSIONS;

[Peter Beverloo, 2014/07/10 11:29:39]

IDS_NOTIFICATION_PERMISSIONS has <ph name="site">,
IDS_MIDI_SYSEX_INFOBAR_QUESTION has <ph name="url"> and
IDS_PUSH_MESSAGES_PERMISSION_QUESTION has <ph name="URL">.

Do these mean anything? Did you confirm that the origin of the permission
request got put in the bubble?

[Miguel Garcia, 2014/07/17 17:24:48]

Yes

On 2014/07/10 11:29:39, Peter Beverloo wrote:

+        break;
       case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
         message_id = IDS_MIDI_SYSEX_INFOBAR_QUESTION;
         break;
@@ -70,6 +76,9 @@ base::string16 PermissionBubbleRequestImpl::GetMessageText() const {
 base::string16 PermissionBubbleRequestImpl::GetMessageTextFragment() const {
   int message_id;
   switch (type_) {
+    case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
+      message_id = IDS_NOTIFICATION_PERMISSIONS_FRAGMENT;
+      break;
     case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
       message_id = IDS_MIDI_SYSEX_PERMISSION_FRAGMENT;
       break;