Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: chrome/browser/chrome_content_browser_client.h

Issue 376253005: Migrate the notification permission to the new common permission classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.h
diff --git a/chrome/browser/chrome_content_browser_client.h b/chrome/browser/chrome_content_browser_client.h
index e42664bafe8a06e0e877a3d132c3d2c82b8e8c0c..c7c41fc9b049f79c364390409a332c68a3e8babe 100644
--- a/chrome/browser/chrome_content_browser_client.h
+++ b/chrome/browser/chrome_content_browser_client.h
@@ -294,6 +294,11 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {
#endif
private:
+ // Used as a callback once a permission has been decided.
+ // TODO(beverloo) remove once the notification callback returns
Peter Beverloo 2014/07/10 11:29:38 s/beverloo/peter/. Elsewhere too.
Miguel Garcia 2014/07/17 17:24:47 Done.
+ // a boolean.
+ void NotificationPermissionRequested(base::Closure callback, bool result);
+
#if defined(ENABLE_WEBRTC)
// Copies disable WebRTC encryption switch depending on the channel.
static void MaybeCopyDisableWebRtcEncryptionSwitch(
@@ -322,6 +327,9 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {
// created. It is used only the IO thread.
prerender::PrerenderTracker* prerender_tracker_;
+ // TODO(beverloo) remove once NotificationPermissionRequested is removed.
+ base::WeakPtrFactory<ChromeContentBrowserClient> weak_factory_;
Peter Beverloo 2014/07/10 11:29:38 #include "base/memory/weak_ptr.h" (IWYU)
Miguel Garcia 2014/07/17 17:24:47 Done.
+
friend class DisableWebRtcEncryptionFlagTest;
DISALLOW_COPY_AND_ASSIGN(ChromeContentBrowserClient);
« no previous file with comments | « no previous file | chrome/browser/chrome_content_browser_client.cc » ('j') | chrome/browser/chrome_content_browser_client.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698