Migrate the notification permission to the new common permission classes.

chrome/browser/chrome_content_browser_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_
 #define CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_
 
 #include <set>
 #include <string>
 #include <utility>
@@ skipping 276 matching lines @@
       int child_process_id,
       std::vector<content::FileDescriptorInfo>* mappings) OVERRIDE;
 #endif
 #if defined(OS_WIN)
   virtual const wchar_t* GetResourceDllName() OVERRIDE;
   virtual void PreSpawnRenderer(sandbox::TargetPolicy* policy,
                                 bool* success) OVERRIDE;
 #endif
 
  private:
+  // Used as a callback once a permission has been decided.
+  // TODO(beverloo) remove once the notification callback returns

[Peter Beverloo, 2014/07/10 11:29:38]

s/beverloo/peter/. Elsewhere too.

[Miguel Garcia, 2014/07/17 17:24:47]

Done.

+  // a boolean.
+  void NotificationPermissionRequested(base::Closure callback, bool result);
+
 #if defined(ENABLE_WEBRTC)
   // Copies disable WebRTC encryption switch depending on the channel.
   static void MaybeCopyDisableWebRtcEncryptionSwitch(
       base::CommandLine* to_command_line,
       const base::CommandLine& from_command_line,
       VersionInfo::Channel channel);
 #endif
 
 #if defined(ENABLE_PLUGINS)
   // Set of origins that can use TCP/UDP private APIs from NaCl.
   std::set<std::string> allowed_socket_origins_;
   // Set of origins that can get a handle for FileIO from NaCl.
   std::set<std::string> allowed_file_handle_origins_;
   // Set of origins that can use "dev chanel" APIs from NaCl, even on stable
   // versions of Chrome.
   std::set<std::string> allowed_dev_channel_origins_;
 #endif
   scoped_ptr<extensions::BrowserPermissionsPolicyDelegate>
       permissions_policy_delegate_;
 
   // The prerender tracker used to determine whether a render process is used
   // for prerendering and an override cookie store must be provided.
   // This needs to be kept as a member rather than just looked up from
   // the profile due to initialization ordering, as well as due to threading.
   // It is initialized on the UI thread when the ResoureDispatcherHost is
   // created. It is used only the IO thread.
   prerender::PrerenderTracker* prerender_tracker_;
 
+  // TODO(beverloo) remove once NotificationPermissionRequested is removed.
+  base::WeakPtrFactory<ChromeContentBrowserClient> weak_factory_;

[Peter Beverloo, 2014/07/10 11:29:38]

#include "base/memory/weak_ptr.h"

(IWYU)

[Miguel Garcia, 2014/07/17 17:24:47]

Done.

+
   friend class DisableWebRtcEncryptionFlagTest;
 
   DISALLOW_COPY_AND_ASSIGN(ChromeContentBrowserClient);
 };
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_CHROME_CONTENT_BROWSER_CLIENT_H_