Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed)

Created:
6 years, 5 months ago by kozyatinskiy1
Modified:
6 years, 4 months ago
Reviewers:
vsevik, aandrey, yurys, pfeldman
CC:
blink-reviews, tzik, eae+blinkwatch, fs, eric.carlson_apple.com, apavlov+blink_chromium.org, kinuko+worker_chromium.org, aandrey+blink_chromium.org, lushnikov+blink_chromium.org, rwlbuis, vsevik+blink_chromium.org, Yoav Weiss, krit, arv+blink, malch+blink_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, yurys+blink_chromium.org, abarth-chromium, nhiroki, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, kinuko+serviceworker, pdr., rune+blink, jsbell+serviceworker_chromium.org, kenneth.christiansen, nessy, loislo+blink_chromium.org, zoltan1, alecflett+watch_chromium.org, sof, caseq+blink_chromium.org, kouhei+svg_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, gyuyoung.kim_webkit.org, darktears, Nate Chapin, vcarbune.chromium, philipj_slow, michaeln, blink-reviews-rendering, serviceworker-reviews, gasubic, leviw+renderwatch, falken, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, f(malita), horo+watch_chromium.org, Stephen Chennney, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse
Project:
blink
Visibility:
Public.

Description

Introduced new class ConsoleMessage, that wraps all old arguments. R=vsevik@chromium.org,aandrey@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179850

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Total comments: 10

Patch Set 5 : #

Patch Set 6 : #

Total comments: 8

Patch Set 7 : #

Total comments: 9

Patch Set 8 : #

Patch Set 9 : #

Total comments: 2

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -79 lines) Patch
M Source/bindings/core/v8/ScriptPreprocessor.cpp View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/core.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 4 5 6 3 chunks +10 lines, -3 lines 0 comments Download
M Source/core/events/TouchEvent.cpp View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/frame/FrameConsole.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/frame/FrameConsole.cpp View 1 2 3 4 5 6 7 3 chunks +14 lines, -22 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 2 3 4 5 4 chunks +6 lines, -3 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/inspector/CodeGeneratorInstrumentation.py View 1 2 3 4 5 6 7 8 4 chunks +7 lines, -0 lines 0 comments Download
A Source/core/inspector/ConsoleMessage.h View 1 2 3 4 5 6 1 chunk +61 lines, -0 lines 0 comments Download
A Source/core/inspector/ConsoleMessage.cpp View 1 2 3 4 5 6 1 chunk +107 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.cpp View 1 2 3 4 5 6 7 6 chunks +16 lines, -20 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.cpp View 1 2 3 4 5 5 chunks +11 lines, -4 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 2 3 4 5 6 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/xml/XSLTProcessorLibxslt.cpp View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 31 (0 generated)
kozyatinskiy1
6 years, 5 months ago (2014-07-11 12:33:13 UTC) #1
yurys
https://codereview.chromium.org/376213002/diff/140001/Source/core/inspector/ConsoleMessage.h File Source/core/inspector/ConsoleMessage.h (right): https://codereview.chromium.org/376213002/diff/140001/Source/core/inspector/ConsoleMessage.h#newcode22 Source/core/inspector/ConsoleMessage.h:22: class ConsoleMessage FINAL: public RefCountedWillBeGarbageCollectedFinalized<ConsoleMessage> { New class could ...
6 years, 5 months ago (2014-07-11 12:36:34 UTC) #2
vsevik
https://chromiumcodereview.appspot.com/376213002/diff/220001/Source/core/frame/csp/CSPDirectiveList.cpp File Source/core/frame/csp/CSPDirectiveList.cpp (right): https://chromiumcodereview.appspot.com/376213002/diff/220001/Source/core/frame/csp/CSPDirectiveList.cpp#newcode134 Source/core/frame/csp/CSPDirectiveList.cpp:134: if (scriptState) Let's extract this to a separate change
6 years, 5 months ago (2014-07-15 14:40:33 UTC) #3
vsevik
https://chromiumcodereview.appspot.com/376213002/diff/220001/Source/core/dom/ExecutionContext.cpp File Source/core/dom/ExecutionContext.cpp (right): https://chromiumcodereview.appspot.com/376213002/diff/220001/Source/core/dom/ExecutionContext.cpp#newcode141 Source/core/dom/ExecutionContext.cpp:141: AccessControlStatus corsStatus = consoleMessage->corsStatus(); corsStatus is only used for ...
6 years, 5 months ago (2014-07-15 14:43:22 UTC) #4
kozyatinskiy1
Added default locations arguments to ConsoleMessage::create. Now, ConsoleMessage is used only for FrameConsole::addMessage and InspectorInstrumentation::addMessage. ...
6 years, 5 months ago (2014-07-24 08:37:12 UTC) #5
aandrey
https://codereview.chromium.org/376213002/diff/300001/Source/core/inspector/ConsoleMessage.cpp File Source/core/inspector/ConsoleMessage.cpp (right): https://codereview.chromium.org/376213002/diff/300001/Source/core/inspector/ConsoleMessage.cpp#newcode15 Source/core/inspector/ConsoleMessage.cpp:15: , m_scriptState(nullptr) m_requestIdentifier(0) https://codereview.chromium.org/376213002/diff/300001/Source/core/inspector/ConsoleMessage.cpp#newcode31 Source/core/inspector/ConsoleMessage.cpp:31: , m_scriptState(nullptr) ditto https://codereview.chromium.org/376213002/diff/300001/Source/core/inspector/ConsoleMessage.h ...
6 years, 5 months ago (2014-07-24 14:05:52 UTC) #6
kozyatinskiy1
https://codereview.chromium.org/376213002/diff/300001/Source/core/inspector/ConsoleMessage.cpp File Source/core/inspector/ConsoleMessage.cpp (right): https://codereview.chromium.org/376213002/diff/300001/Source/core/inspector/ConsoleMessage.cpp#newcode15 Source/core/inspector/ConsoleMessage.cpp:15: , m_scriptState(nullptr) On 2014/07/24 14:05:52, aandrey wrote: > m_requestIdentifier(0) ...
6 years, 5 months ago (2014-07-25 09:58:23 UTC) #7
aandrey
> On 2014/07/24 14:05:52, aandrey wrote: > > RefPtr<ScriptState> > > https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/bindings/core/v8/ScriptState.h&l=21 > ScriptState is ...
6 years, 5 months ago (2014-07-25 10:27:57 UTC) #8
kozyatinskiy1
On 2014/07/25 10:27:57, aandrey wrote: > > On 2014/07/24 14:05:52, aandrey wrote: > > > ...
6 years, 4 months ago (2014-08-04 14:45:46 UTC) #9
aandrey
lgtm, but wait for @vsevik https://codereview.chromium.org/376213002/diff/360001/Source/core/frame/FrameConsole.cpp File Source/core/frame/FrameConsole.cpp (right): https://codereview.chromium.org/376213002/diff/360001/Source/core/frame/FrameConsole.cpp#newcode66 Source/core/frame/FrameConsole.cpp:66: if (consoleMessage->callStack()) { remove ...
6 years, 4 months ago (2014-08-05 07:35:44 UTC) #10
vsevik
lgtm with a nit, provided aandrey@'s comments are addressed https://chromiumcodereview.appspot.com/376213002/diff/360001/Source/core/inspector/ConsoleMessage.cpp File Source/core/inspector/ConsoleMessage.cpp (right): https://chromiumcodereview.appspot.com/376213002/diff/360001/Source/core/inspector/ConsoleMessage.cpp#newcode40 Source/core/inspector/ConsoleMessage.cpp:40: ...
6 years, 4 months ago (2014-08-08 12:35:47 UTC) #11
kozyatinskiy1
https://codereview.chromium.org/376213002/diff/360001/Source/core/frame/FrameConsole.cpp File Source/core/frame/FrameConsole.cpp (right): https://codereview.chromium.org/376213002/diff/360001/Source/core/frame/FrameConsole.cpp#newcode66 Source/core/frame/FrameConsole.cpp:66: if (consoleMessage->callStack()) { On 2014/08/05 07:35:44, aandrey wrote: > ...
6 years, 4 months ago (2014-08-08 13:10:27 UTC) #12
vsevik
https://chromiumcodereview.appspot.com/376213002/diff/380001/Source/core/frame/FrameConsole.cpp File Source/core/frame/FrameConsole.cpp (right): https://chromiumcodereview.appspot.com/376213002/diff/380001/Source/core/frame/FrameConsole.cpp#newcode67 Source/core/frame/FrameConsole.cpp:67: consoleMessage->setURL(consoleMessage->callStack()->at(0).sourceURL()); Please do not update console message object once ...
6 years, 4 months ago (2014-08-08 13:21:02 UTC) #13
kozyatinskiy1
https://codereview.chromium.org/376213002/diff/380001/Source/core/frame/FrameConsole.cpp File Source/core/frame/FrameConsole.cpp (right): https://codereview.chromium.org/376213002/diff/380001/Source/core/frame/FrameConsole.cpp#newcode67 Source/core/frame/FrameConsole.cpp:67: consoleMessage->setURL(consoleMessage->callStack()->at(0).sourceURL()); On 2014/08/08 13:21:01, vsevik wrote: > Please do ...
6 years, 4 months ago (2014-08-08 14:02:13 UTC) #14
vsevik
> https://codereview.chromium.org/376213002/diff/380001/Source/core/inspector/InspectorInstrumentation.idl#newcode482 > Source/core/inspector/InspectorInstrumentation.idl:482: #include > "core/inspector/ConsoleMessage.h" > On 2014/08/08 13:21:01, vsevik wrote: > > ...
6 years, 4 months ago (2014-08-08 14:32:00 UTC) #15
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 4 months ago (2014-08-08 14:32:08 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/376213002/400001
6 years, 4 months ago (2014-08-08 14:33:08 UTC) #17
aandrey
https://codereview.chromium.org/376213002/diff/380001/Source/core/inspector/InspectorInstrumentation.idl File Source/core/inspector/InspectorInstrumentation.idl (right): https://codereview.chromium.org/376213002/diff/380001/Source/core/inspector/InspectorInstrumentation.idl#newcode482 Source/core/inspector/InspectorInstrumentation.idl:482: #include "core/inspector/ConsoleMessage.h" On 2014/08/08 14:02:13, kozyatinskiy wrote: > On ...
6 years, 4 months ago (2014-08-08 15:00:54 UTC) #18
aandrey
The CQ bit was unchecked by aandrey@chromium.org
6 years, 4 months ago (2014-08-08 15:01:31 UTC) #19
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-08-08 15:01:50 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/376213002/400001
6 years, 4 months ago (2014-08-08 15:01:58 UTC) #21
kozyatinskiy1
On 2014/08/08 15:00:54, aandrey wrote: > https://codereview.chromium.org/376213002/diff/380001/Source/core/inspector/InspectorInstrumentation.idl > File Source/core/inspector/InspectorInstrumentation.idl (right): > > https://codereview.chromium.org/376213002/diff/380001/Source/core/inspector/InspectorInstrumentation.idl#newcode482 > ...
6 years, 4 months ago (2014-08-08 15:10:29 UTC) #22
kozyatinskiy1
Added forward declaration support to codegenerator based on @aandrey reverted patch: https://codereview.chromium.org/383123009/ @pfeldman or @yurus, ...
6 years, 4 months ago (2014-08-08 15:40:03 UTC) #23
pfeldman
bindings/ lgtm
6 years, 4 months ago (2014-08-08 15:41:31 UTC) #24
aandrey
https://codereview.chromium.org/376213002/diff/420001/Source/core/inspector/InspectorInstrumentation.idl File Source/core/inspector/InspectorInstrumentation.idl (right): https://codereview.chromium.org/376213002/diff/420001/Source/core/inspector/InspectorInstrumentation.idl#newcode483 Source/core/inspector/InspectorInstrumentation.idl:483: #include "core/inspector/ScriptCallStack.h" unused include
6 years, 4 months ago (2014-08-08 15:48:03 UTC) #25
kozyatinskiy1
The CQ bit was checked by kozyatinskiy@google.com
6 years, 4 months ago (2014-08-08 15:48:06 UTC) #26
kozyatinskiy1
The CQ bit was unchecked by kozyatinskiy@google.com
6 years, 4 months ago (2014-08-08 15:48:07 UTC) #27
kozyatinskiy1
https://codereview.chromium.org/376213002/diff/420001/Source/core/inspector/InspectorInstrumentation.idl File Source/core/inspector/InspectorInstrumentation.idl (right): https://codereview.chromium.org/376213002/diff/420001/Source/core/inspector/InspectorInstrumentation.idl#newcode483 Source/core/inspector/InspectorInstrumentation.idl:483: #include "core/inspector/ScriptCallStack.h" On 2014/08/08 15:48:03, aandrey wrote: > unused ...
6 years, 4 months ago (2014-08-08 15:51:13 UTC) #28
kozyatinskiy1
The CQ bit was checked by kozyatinskiy@google.com
6 years, 4 months ago (2014-08-08 15:52:10 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/376213002/440001
6 years, 4 months ago (2014-08-08 15:52:30 UTC) #30
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 18:16:48 UTC) #31
Message was sent while issue was closed. 
Change committed as 179850

Powered by Google App Engine
This is Rietveld 408576698