DevTools: Make FrameConsole methods accept ConsoleMessage objects.

Source/core/inspector/ConsoleMessage.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ConsoleMessage_h
+#define ConsoleMessage_h
+
+#include "core/frame/ConsoleTypes.h"
+#include "core/inspector/ScriptCallStack.h"
+#include "wtf/Forward.h"
+#include "wtf/PassRefPtr.h"
+#include "wtf/RefCounted.h"
+#include "wtf/text/WTFString.h"
+
+namespace WebCore {
+
+class ScriptCallStack;
+class ScriptState;
+
+class ConsoleMessage FINAL: public RefCounted<ConsoleMessage> {
+public:
+    static PassRefPtr<ConsoleMessage> create(MessageSource source, MessageLevel level, const String& message, const String& url = String(), unsigned lineNumber = 0, unsigned columnNumber = 0)
+    {
+        return adoptRef(new ConsoleMessage(source, level, message, url, lineNumber, columnNumber));
+    }
+
+    void setCallStack(PassRefPtr<ScriptCallStack>);
+    void setScriptState(ScriptState*);
+    void setRequestIdentifier(unsigned long);
+
+    void setURL(const String&);
+    void setLineNumber(unsigned);
+
+    MessageSource source();

[aandrey, 2014/07/24 14:05:52]

MessageSource source() const;
ditto for the accessors below

[kozyatinskiy1, 2014/07/25 09:58:22]

Done.

+    MessageLevel level();
+    const String& message();
+    const String& url();
+    unsigned lineNumber();
+    unsigned columnNumber();
+    PassRefPtr<ScriptCallStack> callStack();
+    ScriptState* scriptState();
+    unsigned long requestIdentifier();
+
+private:
+    ConsoleMessage();
+    ConsoleMessage(MessageSource, MessageLevel, const String& message, const String& url = String(), unsigned lineNumber = 0, unsigned columnNumber = 0);
+
+    MessageSource m_source;
+    MessageLevel m_level;
+    String m_message;
+    String m_url;
+    unsigned m_lineNumber;
+    unsigned m_columnNumber;
+    RefPtr<ScriptCallStack> m_callStack;
+    ScriptState* m_scriptState;

[aandrey, 2014/07/24 14:05:52]

RefPtr<ScriptState>

[kozyatinskiy1, 2014/07/25 09:58:22]

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
ScriptState is garbage collected V8. I suppose that I can't control life time of
this state by blink RefPtr. Am I wrong?

+    unsigned long m_requestIdentifier;
+};
+
+} // namespace WebCore
+
+#endif // ConsoleMessage_h