Issue 376163002: DevTools: Search across files should work for file:folderName queries.

Issue 376163002: DevTools: Search across files should work for file:folderName queries. (Closed)

Created:
6 years, 5 months ago by vsevik

Modified:
6 years, 5 months ago

Reviewers:
apavlov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Search across files should work for file:folderName queries. BUG=368216 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178031

Patch Set 1 #

Patch Set 2 : Added test #

Total comments: 1

Patch Set 3 : Comments addressed #

Patch Set 4 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -43 lines)			Patch
M	LayoutTests/http/tests/inspector-enabled/search/sources-search-scope.html	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	LayoutTests/http/tests/inspector-enabled/search/sources-search-scope-expected.txt	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
M	LayoutTests/http/tests/inspector/search/sources-search-scope-in-files.html	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	LayoutTests/http/tests/inspector/search/sources-search-scope-in-files-expected.txt	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/sdk/ContentProviderBasedProjectDelegate.js	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/sdk/FileSystemWorkspaceBinding.js	View	1 2	3 chunks	+6 lines, -17 lines	0 comments	Download
M	Source/devtools/front_end/sdk/Workspace.js	View	1 2	2 chunks	+5 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/sources/SourcesSearchScope.js	View	1 2	2 chunks	+30 lines, -20 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

apavlov

lgtm https://codereview.chromium.org/376163002/diff/20001/Source/devtools/front_end/search/SourcesSearchScope.js File Source/devtools/front_end/search/SourcesSearchScope.js (right): https://codereview.chromium.org/376163002/diff/20001/Source/devtools/front_end/search/SourcesSearchScope.js#newcode160 Source/devtools/front_end/search/SourcesSearchScope.js:160: files = files.concat(this._projectFilesMatchingFileQuery(project, this._searchConfig, true)); This could be ...

6 years, 5 months ago (2014-07-09 14:00:20 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/376163002/60001

6 years, 5 months ago (2014-07-14 06:13:35 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...

6 years, 5 months ago (2014-07-14 07:16:18 UTC) #5

Message was sent while issue was closed.

Change committed as 178031

Expand Messages | Collapse Messages