Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Unified Diff: Source/devtools/front_end/sdk/ContentProviderBasedProjectDelegate.js

Issue 376163002: DevTools: Search across files should work for file:folderName queries. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/ContentProviderBasedProjectDelegate.js
diff --git a/Source/devtools/front_end/sdk/ContentProviderBasedProjectDelegate.js b/Source/devtools/front_end/sdk/ContentProviderBasedProjectDelegate.js
index 562e718b8bd3ba4a1eb53c055b315f0cf639f0f5..deeb3d4935911b07c9ae4832a92192b3f6a43a99 100644
--- a/Source/devtools/front_end/sdk/ContentProviderBasedProjectDelegate.js
+++ b/Source/devtools/front_end/sdk/ContentProviderBasedProjectDelegate.js
@@ -217,13 +217,14 @@ WebInspector.ContentProviderBasedProjectDelegate.prototype = {
/**
* @param {!WebInspector.ProjectSearchConfig} searchConfig
+ * @param {!Array.<string>} filesMathingFileQuery
* @param {!WebInspector.Progress} progress
* @param {function(!Array.<string>)} callback
*/
- findFilesMatchingSearchRequest: function(searchConfig, progress, callback)
+ findFilesMatchingSearchRequest: function(searchConfig, filesMathingFileQuery, progress, callback)
{
var result = [];
- var paths = Object.keys(this._contentProviders);
+ var paths = filesMathingFileQuery;
var totalCount = paths.length;
if (totalCount === 0) {
// searchInContent should call back later.
@@ -231,7 +232,6 @@ WebInspector.ContentProviderBasedProjectDelegate.prototype = {
return;
}
- paths = paths.filter(searchConfig.filePathMatchesFileQuery.bind(searchConfig));
var barrier = new CallbackBarrier();
progress.setTotalWork(paths.length);
for (var i = 0; i < paths.length; ++i)

Powered by Google App Engine
This is Rietveld 408576698