Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
376133004:
[Refactor] Use isEmailField() for input element. (Closed)
|
Created:
6 years, 5 months ago by pals Modified:
6 years, 5 months ago Reviewers:
Ilya Sherman CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
Description[Refactor] Use isEmailField() for input element.
BUG=None
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282334
Patch Set 1 #
Total comments: 4
Patch Set 2 : nits fixed #Messages
Total messages: 11 (0 generated)
CL https://codereview.chromium.org/375313002/ which exposes isEmailField() interface. PTAL.
Thanks. LGTM with nits addressed: https://codereview.chromium.org/376133004/diff/1/components/autofill/content/... File components/autofill/content/renderer/autofill_agent.cc (right): https://codereview.chromium.org/376133004/diff/1/components/autofill/content/... components/autofill/content/renderer/autofill_agent.cc:84: element.isEmailField()) { nit: No need for this line to wrap anymore. https://codereview.chromium.org/376133004/diff/1/components/autofill/content/... components/autofill/content/renderer/autofill_agent.cc:418: input_element->isEmailField()) { nit: No need for this line to wrap anymore.
Fixed. https://codereview.chromium.org/376133004/diff/1/components/autofill/content/... File components/autofill/content/renderer/autofill_agent.cc (right): https://codereview.chromium.org/376133004/diff/1/components/autofill/content/... components/autofill/content/renderer/autofill_agent.cc:84: element.isEmailField()) { On 2014/07/09 23:17:51, Ilya Sherman wrote: > nit: No need for this line to wrap anymore. Done. https://codereview.chromium.org/376133004/diff/1/components/autofill/content/... components/autofill/content/renderer/autofill_agent.cc:418: input_element->isEmailField()) { On 2014/07/09 23:17:51, Ilya Sherman wrote: > nit: No need for this line to wrap anymore. Done.
The CQ bit was checked by sanjoy.pal@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/376133004/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...) android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...) android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...) linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...) linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...) linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...) linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...) linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...) mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...) win8_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...) win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...) linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/26893) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/31331)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
The CQ bit was checked by sanjoy.pal@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/376133004/20001
Message was sent while issue was closed.
Change committed as 282334 |
