[Refactor] Use isEmailField() for input element.

components/autofill/content/renderer/autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_split.h"
@@ skipping 63 matching lines @@
                             std::vector<base::string16>* values,
                             std::vector<base::string16>* labels) {
   WebElementCollection options = element.dataListOptions();
   if (options.isNull())
     return;
 
   base::string16 prefix;
   if (!ignore_current_value) {
     prefix = element.editingValue();
     if (element.isMultiple() &&
-        element.formControlType() == WebString::fromUTF8("email")) {
+        element.isEmailField()) {

[Ilya Sherman, 2014/07/09 23:17:51]

nit: No need for this line to wrap anymore.

[pals, 2014/07/10 06:25:12]

Done.

       std::vector<base::string16> parts;
       base::SplitStringDontTrim(prefix, ',', &parts);
       if (parts.size() > 0) {
         base::TrimWhitespace(parts[parts.size() - 1], base::TRIM_LEADING,
                              &prefix);
       }
     }
   }
   for (WebOptionElement option = options.firstItem().to<WebOptionElement>();
        !option.isNull(); option = options.nextItem().to<WebOptionElement>()) {
@@ skipping 313 matching lines @@
 }
 
 void AutofillAgent::AcceptDataListSuggestion(
     const base::string16& suggested_value) {
   WebInputElement* input_element = toWebInputElement(&element_);
   DCHECK(input_element);
   base::string16 new_value = suggested_value;
   // If this element takes multiple values then replace the last part with
   // the suggestion.
   if (input_element->isMultiple() &&
-      input_element->formControlType() == WebString::fromUTF8("email")) {
+      input_element->isEmailField()) {

[Ilya Sherman, 2014/07/09 23:17:51]

nit: No need for this line to wrap anymore.

[pals, 2014/07/10 06:25:12]

Done.

     std::vector<base::string16> parts;
 
     base::SplitStringDontTrim(input_element->editingValue(), ',', &parts);
     if (parts.size() == 0)
       parts.push_back(base::string16());
 
     base::string16 last_part = parts.back();
     // We want to keep just the leading whitespace.
     for (size_t i = 0; i < last_part.size(); ++i) {
       if (!IsWhitespace(last_part[i])) {
@@ skipping 292 matching lines @@
     // parsed form.
     if (frame && !frame->parent() && !frame->isLoading()) {
       ProcessForms(*frame);
       password_autofill_agent_->OnDynamicFormsSeen(frame);
       return;
     }
   }
 }
 
 }  // namespace autofill