chrome/browser/component_updater/sw_reporter_installer_win.cc - Issue 375973003: Componentize component_updater: Use Configurator to build query parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/sw_reporter_installer_win.cc

Issue 375973003: Componentize component_updater: Use Configurator to build query parameters. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix one gyp omission Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/component_updater/component_updater_utils.h ('K') | « chrome/browser/component_updater/pepper_flash_component_installer.cc ('k') | chrome/browser/component_updater/test/test_configurator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/sw_reporter_installer_win.cc

diff --git a/chrome/browser/component_updater/sw_reporter_installer_win.cc b/chrome/browser/component_updater/sw_reporter_installer_win.cc

index 513362f08f8590aef98f1d390f382a31ab0febfa..4be32d7f8a98e2614c419ff1065162201cd2a17f 100644

--- a/chrome/browser/component_updater/sw_reporter_installer_win.cc

+++ b/chrome/browser/component_updater/sw_reporter_installer_win.cc

@@ -28,8 +28,7 @@

#include "chrome/browser/component_updater/component_updater_service.h"

#include "chrome/browser/component_updater/component_updater_utils.h"

#include "chrome/browser/component_updater/default_component_installer.h"

-#include "chrome/common/chrome_paths.h"

-#include "chrome/common/pref_names.h"

+#include "components/component_updater/pref_names.h"

#include "content/public/browser/browser_thread.h"

using content::BrowserThread;

@@ -162,8 +161,8 @@ class SwReporterInstallerTraits : public ComponentInstallerTraits {

// The base directory on windows looks like:

// <profile>\AppData\Local\Google\Chrome\User Data\SwReporter\.

base::FilePath result;

- PathService::Get(chrome::DIR_USER_DATA, &result);

- return result.Append(FILE_PATH_LITERAL("SwReporter"));

+ PathService::Get(DIR_SW_REPORTER, &result);

+ return result;

}

static std::string ID() {