Componentize component_updater: Use Configurator to build query parameters.

chrome/browser/component_updater/component_updater_utils.h

Index: chrome/browser/component_updater/component_updater_utils.h
diff --git a/chrome/browser/component_updater/component_updater_utils.h b/chrome/browser/component_updater/component_updater_utils.h
index 7c238d28ed8dc8b7c871c31e8e8edaa837674d8e..01bab6818f6707906a602d4ec35c103f0d79562a 100644
--- a/chrome/browser/component_updater/component_updater_utils.h
+++ b/chrome/browser/component_updater/component_updater_utils.h
@@ -22,6 +22,7 @@ class URLRequestContextGetter;
 
 namespace component_updater {
 
+class Configurator;
 struct CrxUpdateItem;
 
 // An update protocol request starts with a common preamble which includes
@@ -44,7 +45,8 @@ struct CrxUpdateItem;
 // If specified, |additional_attributes| are appended as attributes of the
 // request element. The additional attributes have to be well-formed for
 // insertion in the request element.
-std::string BuildProtocolRequest(const std::string& request_body,
+std::string BuildProtocolRequest(const Configurator& config,

[Sorin Jianu, 2014/07/09 08:29:16]

I would prefer a design where these low level formatting utilities don't take a
dependency of the configurator, instead, they take the parameters needed to
build the request. These utilities are called by objects that need to send
network requests, such as PingManager/PingSender, and the UpdateChecker. These
objects can take a dependency on the configurator, retrieve the ambient
parameters needed (including the new ones), then build the request by formatting
the tags.

[tommycli, 2014/07/09 19:48:11]

Done.

+                                 const std::string& request_body,
                                  const std::string& additional_attributes);
 
 // Sends a protocol request to the the service endpoint specified by |url|.