Componentize component_updater: Use Configurator to build query parameters.

chrome/browser/component_updater/component_updater_configurator.h

Index: chrome/browser/component_updater/component_updater_configurator.h
diff --git a/chrome/browser/component_updater/component_updater_configurator.h b/chrome/browser/component_updater/component_updater_configurator.h
index 9cb73bd836083bf9251f943994185d4df7d07d3b..6527e33ba3585a50ba76c3d300b86f787d35c250 100644
--- a/chrome/browser/component_updater/component_updater_configurator.h
+++ b/chrome/browser/component_updater/component_updater_configurator.h
@@ -7,6 +7,8 @@
 
 #include <string>
 
+#include "base/version.h"

[Sorin Jianu, 2014/07/09 08:29:16]

A forward decl for base::Version would be sufficient (the declaration of A f();
does not need the definition of A) , please try to see if it compiles.

[tommycli, 2014/07/09 19:48:10]

Done. Had no idea that this was possible. I guess you learn something new
everyday.

+
 class GURL;
 
 namespace base {
@@ -53,11 +55,23 @@ class Configurator {
   // pings are disabled.
   virtual GURL PingUrl() const = 0;
 
+  // Version of the application. Used to compare to component manifests.
+  virtual base::Version ApplicationVersion() const = 0;
+
+  // Parameters added to each url request that specify the current platform.
+  // The return string must be safe for insertion as an attribute in an
+  // XML element.
+  virtual std::string PlatformRequestParams() const = 0;
+
   // Parameters added to each url request. It can be empty if none are needed.
   // The return string must be safe for insertion as an attribute in an
   // XML element.
   virtual std::string ExtraRequestParams() const = 0;
 
+  // Tag added to the body of each url request. Specifies the platform
+  // name and version. This is a self-closing XML tag.
+  virtual std::string RequestOSTag() const = 0;
+
   // How big each update request can be. Don't go above 2000.
   virtual size_t UrlSizeLimit() const = 0;