Componentize component_updater: Use Configurator to build query parameters.

chrome/browser/component_updater/component_updater_configurator.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_CONFIGURATOR_H_
 #define CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_CONFIGURATOR_H_
 
 #include <string>
 
+#include "base/version.h"

[Sorin Jianu, 2014/07/09 08:29:16]

A forward decl for base::Version would be sufficient (the declaration of A f();
does not need the definition of A) , please try to see if it compiles.

[tommycli, 2014/07/09 19:48:10]

Done. Had no idea that this was possible. I guess you learn something new
everyday.

+
 class GURL;
 
 namespace base {
 class CommandLine;
 }
 
 namespace net {
 class URLRequestContextGetter;
 }
 
@@ skipping 26 matching lines @@
   // for the same component.
   virtual int OnDemandDelay() const = 0;
 
   // The url that is going to be used update checks over Omaha protocol.
   virtual GURL UpdateUrl() const = 0;
 
   // The url where the completion pings are sent. Invalid if and only if
   // pings are disabled.
   virtual GURL PingUrl() const = 0;
 
+  // Version of the application. Used to compare to component manifests.
+  virtual base::Version ApplicationVersion() const = 0;
+
+  // Parameters added to each url request that specify the current platform.
+  // The return string must be safe for insertion as an attribute in an
+  // XML element.
+  virtual std::string PlatformRequestParams() const = 0;
+
   // Parameters added to each url request. It can be empty if none are needed.
   // The return string must be safe for insertion as an attribute in an
   // XML element.
   virtual std::string ExtraRequestParams() const = 0;
 
+  // Tag added to the body of each url request. Specifies the platform
+  // name and version. This is a self-closing XML tag.
+  virtual std::string RequestOSTag() const = 0;
+
   // How big each update request can be. Don't go above 2000.
   virtual size_t UrlSizeLimit() const = 0;
 
   // The source of contexts for all the url requests.
   virtual net::URLRequestContextGetter* RequestContext() const = 0;
 
   // True means that all ops are performed in this process.
   virtual bool InProcess() const = 0;
 
   // True means that this client can handle delta updates.
   virtual bool DeltasEnabled() const = 0;
 
   // True means that the background downloader can be used for downloading
   // non on-demand components.
   virtual bool UseBackgroundDownloader() const = 0;
 };
 
 Configurator* MakeChromeComponentUpdaterConfigurator(
     const base::CommandLine* cmdline,
     net::URLRequestContextGetter* context_getter);
 
 }  // namespace component_updater
 
 #endif  // CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_CONFIGURATOR_H_