Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Issue 375863006: Remove useless options from bench (Closed)

Created:
6 years, 5 months ago by kelvinly
Modified:
6 years, 5 months ago
CC:
reviews_skia.org, mtklein
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove useless options from bench BUG=skia: Committed: https://skia.googlesource.com/skia/+/762c7188247332a7ee4d108d0c4291b92815aec2

Patch Set 1 #

Patch Set 2 : Fixed build. Dunno why it didn't show up with "make tools" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -21 lines) Patch
M bench/Benchmark.h View 2 chunks +0 lines, -10 lines 0 comments Download
M bench/Benchmark.cpp View 1 2 chunks +2 lines, -5 lines 0 comments Download
M bench/benchmain.cpp View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
kelvinly
I removed the right ones right?
6 years, 5 months ago (2014-07-08 20:51:10 UTC) #1
tfarina
I think you could have trimmed the reviewers list. I'd say Mike is a good ...
6 years, 5 months ago (2014-07-09 00:22:26 UTC) #2
bsalomon
These are the options we discussed. I think they made more sense earlier in bench's ...
6 years, 5 months ago (2014-07-09 13:16:22 UTC) #3
reed1
lgtm
6 years, 5 months ago (2014-07-09 13:32:37 UTC) #4
kelvinly
On 2014/07/09 13:32:37, reed1 wrote: > lgtm So just a heads up, I'm guessing I'll ...
6 years, 5 months ago (2014-07-09 13:56:33 UTC) #5
benchen
On 2014/07/09 13:56:33, kelvinly wrote: > On 2014/07/09 13:32:37, reed1 wrote: > > lgtm > ...
6 years, 5 months ago (2014-07-09 14:00:40 UTC) #6
kelvinly
The CQ bit was checked by kelvinly@google.com
6 years, 5 months ago (2014-07-09 17:34:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kelvinly@google.com/375863006/1
6 years, 5 months ago (2014-07-09 17:35:04 UTC) #8
kelvinly
The CQ bit was unchecked by kelvinly@google.com
6 years, 5 months ago (2014-07-09 17:44:21 UTC) #9
kelvinly
The CQ bit was checked by kelvinly@google.com
6 years, 5 months ago (2014-07-09 18:22:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kelvinly@google.com/375863006/20001
6 years, 5 months ago (2014-07-09 18:23:15 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 19:25:33 UTC) #12
Message was sent while issue was closed.
Change committed as 762c7188247332a7ee4d108d0c4291b92815aec2

Powered by Google App Engine
This is Rietveld 408576698