Changes Mac removable device listing to include all attached USB drives.

Changes Mac removable device listing to include all attached USB drives.

Some drives do not report themselves as removable despite appearing to a user to be a removable drive. Particularly this is the case for some USB sticks. We are fixing this by changing the device listing to list all drives that are either removable or attached via USB. We have already done a similar change for Chrome OS due to some SD card readers listing themselves as non-removable. Chrome OS lists all SD or USB drives. However, we do not have a reliable way to detect SD cards on Windows and Mac so we will continue to use the removable flag.

BUG=391998
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282166

[Drew Haven, 2014-07-08 22:37:36]

Robert,

We're relaxing the requirements on the removable-device listing for the recovery
tool.  We found out that even some USB drives list themselves as non-removable. 
So we are changing it to all IOMedia devices that are removable or USB.

I had to update the check in the utility writer too, so I did finally add some
common code.

If you have some time this week, could you please take a look at this CL?

-- Drew

[Robert Sesek, 2014-07-09 01:01:12]

LGTM

https://codereview.chromium.org/375703004/diff/40001/chrome/common/extensions...
File chrome/common/extensions/image_writer/image_writer_util_mac.cc (right):

https://codereview.chromium.org/375703004/diff/40001/chrome/common/extensions...
chrome/common/extensions/image_writer/image_writer_util_mac.cc:34:
kCFCompareEqualTo) {
nit: indent 4 more

https://codereview.chromium.org/375703004/diff/40001/chrome/common/extensions...
File chrome/common/extensions/image_writer/image_writer_util_mac.h (right):

https://codereview.chromium.org/375703004/diff/40001/chrome/common/extensions...
chrome/common/extensions/image_writer/image_writer_util_mac.h:3: // found in the
LICENSE file.
nit: blank line after

https://codereview.chromium.org/375703004/diff/40001/chrome/common/extensions...
chrome/common/extensions/image_writer/image_writer_util_mac.h:11: bool
IsUsbDevice(io_object_t disk_obj);
Needs a comment both describing what it does and about the ownership of the
object.

[Drew Haven, 2014-07-09 18:27:08]

The CQ bit was checked by haven@chromium.org

[Drew Haven, 2014-07-09 18:27:20]

https://codereview.chromium.org/375703004/diff/40001/chrome/common/extensions...
File chrome/common/extensions/image_writer/image_writer_util_mac.cc (right):

https://codereview.chromium.org/375703004/diff/40001/chrome/common/extensions...
chrome/common/extensions/image_writer/image_writer_util_mac.cc:34:
kCFCompareEqualTo) {
On 2014/07/09 01:01:12, rsesek (OOO July 9-13) wrote:
> nit: indent 4 more

Interesting.  "git cl format" actually corrects it back to this indentation. 
It's either using just a bare 4-space indent or lining it up with the open
parenthesis.  I'm going to go with what the clang format does because otherwise
it will just get corrected next time I run the command with a modification on
this file.

https://codereview.chromium.org/375703004/diff/40001/chrome/common/extensions...
File chrome/common/extensions/image_writer/image_writer_util_mac.h (right):

https://codereview.chromium.org/375703004/diff/40001/chrome/common/extensions...
chrome/common/extensions/image_writer/image_writer_util_mac.h:3: // found in the
LICENSE file.
On 2014/07/09 01:01:12, rsesek (OOO July 9-13) wrote:
> nit: blank line after

Done.

https://codereview.chromium.org/375703004/diff/40001/chrome/common/extensions...
chrome/common/extensions/image_writer/image_writer_util_mac.h:11: bool
IsUsbDevice(io_object_t disk_obj);
On 2014/07/09 01:01:12, rsesek (OOO July 9-13) wrote:
> Needs a comment both describing what it does and about the ownership of the
> object.

Done.

[commit-bot: I haz the power, 2014-07-09 18:29:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haven@chromium.org/375703004/60001

[commit-bot: I haz the power, 2014-07-09 23:11:18]

Change committed as 282166