chrome/common/extensions/image_writer/image_writer_util_mac.h - Issue 375703004: Changes Mac removable device listing to include all attached USB drives.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/image_writer/image_writer_util_mac.h

Issue 375703004: Changes Mac removable device listing to include all attached USB drives. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes import order. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/common/extensions/image_writer/OWNERS ('k') | chrome/common/extensions/image_writer/image_writer_util_mac.cc » ('j') | chrome/common/extensions/image_writer/image_writer_util_mac.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.
	Robert Sesek 2014/07/09 01:01:12 nit: blank line after nit: blank line after Drew Haven 2014/07/09 18:27:20 Done. Show quoted text On 2014/07/09 01:01:12, rsesek (OOO July 9-13) wrote: > nit: blank line after Done.
	4 #ifndef CHROME_COMMON_EXTENSIONS_IMAGE_WRITER_IMAGE_WRITER_UTIL_MAC_H

	5 #define CHROME_COMMON_EXTENSIONS_IMAGE_WRITER_IMAGE_WRITER_UTIL_MAC_H

	6

	7 #include <IOKit/IOKitLib.h>

	8

	9 namespace extensions {

	10

	11 bool IsUsbDevice(io_object_t disk_obj);
	Robert Sesek 2014/07/09 01:01:12 Needs a comment both describing what it does and a Needs a comment both describing what it does and about the ownership of the object. Drew Haven 2014/07/09 18:27:20 Done. Show quoted text On 2014/07/09 01:01:12, rsesek (OOO July 9-13) wrote: > Needs a comment both describing what it does and about the ownership of the > object. Done.
	12

	13 } // namespace extensions

	14

	15 #endif // CHROME_COMMON_EXTENSIONS_IMAGE_WRITER_IMAGE_WRITER_UTIL_MAC_H

OLD	NEW