Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 375503005: Drop histograms suffixes for the SpdyCwnd field trial. (Closed)

Created:
6 years, 5 months ago by ppi
Modified:
6 years, 5 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Drop histograms suffixes for the SpdyCwnd field trial. This CL drops recording histogram suffixes for SpdyCwnd field trial from 2010. These are based on depracated timing information recorded in DocumentState and have no indicated owner. BUG=384330 R=isherman@chromium.org, tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281748

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Add Will's tribute to the suffix definition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -24 lines) Patch
M chrome/renderer/page_load_histograms.cc View 1 1 chunk +0 lines, -24 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ppi
Tony, Ilya - please take a look. Tony, can you think of anyone we should ...
6 years, 5 months ago (2014-07-07 12:05:43 UTC) #1
tonyg
lgtm Will would probably care most about this. If it is still useful, we should ...
6 years, 5 months ago (2014-07-07 14:43:45 UTC) #2
Ilya Sherman
+Alexei: Does <obsolete> interact sensibly with <histogram_suffixes>? No need to block this CL on answering ...
6 years, 5 months ago (2014-07-07 23:11:56 UTC) #3
willchan no longer on Chromium
We do like to look at the historical data here. Can we keep these around? ...
6 years, 5 months ago (2014-07-07 23:16:53 UTC) #4
Ilya Sherman
On 2014/07/07 23:16:53, willchan wrote: > We do like to look at the historical data ...
6 years, 5 months ago (2014-07-07 23:18:26 UTC) #5
willchan no longer on Chromium
http://37.media.tumblr.com/tumblr_m9tytmeVMP1r1mr1po1_500.gif
6 years, 5 months ago (2014-07-07 23:23:33 UTC) #6
ppi
Thanks! I added Will as the owner of the suffix. There's already a few histogram_suffixes ...
6 years, 5 months ago (2014-07-08 14:25:23 UTC) #7
ppi
The CQ bit was checked by ppi@chromium.org
6 years, 5 months ago (2014-07-08 14:25:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/375503005/40001
6 years, 5 months ago (2014-07-08 14:27:06 UTC) #9
ppi
6 years, 5 months ago (2014-07-08 14:40:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 manually as r281748 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698