Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Side by Side Diff: chrome/renderer/page_load_histograms.cc

Issue 375503005: Drop histograms suffixes for the SpdyCwnd field trial. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add Will's tribute to the suffix definition. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/page_load_histograms.h" 5 #include "chrome/renderer/page_load_histograms.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 645 matching lines...) Expand 10 before | Expand all | Expand 10 after
656 break; 656 break;
657 case DocumentState::LINK_LOAD_CACHE_STALE_OK: 657 case DocumentState::LINK_LOAD_CACHE_STALE_OK:
658 PLT_HISTOGRAM( 658 PLT_HISTOGRAM(
659 "PLT.BeginToFinish_LinkLoadStaleOk_ExtensionWebRequest", 659 "PLT.BeginToFinish_LinkLoadStaleOk_ExtensionWebRequest",
660 begin_to_finish_all_loads); 660 begin_to_finish_all_loads);
661 break; 661 break;
662 default: 662 default:
663 break; 663 break;
664 } 664 }
665 } 665 }
666
667 // Record SpdyCwnd results.
668 if (document_state->was_fetched_via_spdy()) {
669 switch (load_type) {
670 case DocumentState::LINK_LOAD_NORMAL:
671 PLT_HISTOGRAM("PLT.BeginToFinish_LinkLoadNormal_cwndDynamic",
672 begin_to_finish_all_loads);
673 PLT_HISTOGRAM("PLT.StartToFinish_LinkLoadNormal_cwndDynamic",
674 start_to_finish_all_loads);
675 PLT_HISTOGRAM("PLT.StartToCommit_LinkLoadNormal_cwndDynamic",
676 start_to_commit);
677 break;
678 case DocumentState::NORMAL_LOAD:
679 PLT_HISTOGRAM("PLT.BeginToFinish_NormalLoad_cwndDynamic",
680 begin_to_finish_all_loads);
681 PLT_HISTOGRAM("PLT.StartToFinish_NormalLoad_cwndDynamic",
682 start_to_finish_all_loads);
683 PLT_HISTOGRAM("PLT.StartToCommit_NormalLoad_cwndDynamic",
684 start_to_commit);
685 break;
686 default:
687 break;
688 }
689 }
690 } 666 }
691 667
692 } // namespace 668 } // namespace
693 669
694 PageLoadHistograms::PageLoadHistograms(content::RenderView* render_view) 670 PageLoadHistograms::PageLoadHistograms(content::RenderView* render_view)
695 : content::RenderViewObserver(render_view) { 671 : content::RenderViewObserver(render_view) {
696 } 672 }
697 673
698 void PageLoadHistograms::Dump(WebFrame* frame) { 674 void PageLoadHistograms::Dump(WebFrame* frame) {
699 // We only dump histograms for main frames. 675 // We only dump histograms for main frames.
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
778 754
779 DCHECK(document_state); 755 DCHECK(document_state);
780 DCHECK(ds); 756 DCHECK(ds);
781 GURL url(ds->request().url()); 757 GURL url(ds->request().url());
782 Time start = document_state->start_load_time(); 758 Time start = document_state->start_load_time();
783 Time finish = document_state->finish_load_time(); 759 Time finish = document_state->finish_load_time();
784 // TODO(mbelshe): should we log more stats? 760 // TODO(mbelshe): should we log more stats?
785 VLOG(1) << "PLT: " << (finish - start).InMilliseconds() << "ms " 761 VLOG(1) << "PLT: " << (finish - start).InMilliseconds() << "ms "
786 << url.spec(); 762 << url.spec();
787 } 763 }
OLDNEW
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698