Source/modules/webaudio/OfflineAudioContext.cpp - Issue 375383002: Extending supported sample rate from 3.0KHz to 192.0KHz for OfflineAudioContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/OfflineAudioContext.cpp

Issue 375383002: Extending supported sample rate from 3.0KHz to 192.0KHz for OfflineAudioContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update layoutTest Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/webaudio/AudioContext.cpp ('K') | « Source/modules/webaudio/AudioContext.cpp ('k') | Source/platform/audio/HRTFPanner.cpp » ('j') | Source/platform/audio/HRTFPanner.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/OfflineAudioContext.cpp

diff --git a/Source/modules/webaudio/OfflineAudioContext.cpp b/Source/modules/webaudio/OfflineAudioContext.cpp

index bed82c16d9a7bb2413686feed7857a9dd4ae2baf..31f387654a053aa5bbeb043decf018823b20427d 100644

--- a/Source/modules/webaudio/OfflineAudioContext.cpp

+++ b/Source/modules/webaudio/OfflineAudioContext.cpp

@@ -67,7 +67,7 @@ PassRefPtrWillBeRawPtr<OfflineAudioContext> OfflineAudioContext::create(Executio

}

if (!isSampleRateRangeGood(sampleRate)) {

- exceptionState.throwDOMException(SyntaxError, "sample rate (" + String::number(sampleRate) + ") must be in the range 44100-96000 Hz.");

+ exceptionState.throwDOMException(SyntaxError, "sample rate (" + String::number(sampleRate) + ") must be in the range 8000-96000 Hz.");

Raymond Toy 2014/07/30 16:49:38 Probably a good time to replace this with Exceptio

KhNo 2014/07/31 16:45:54 Thanks for good recommend.

return nullptr;

}

« Source/modules/webaudio/AudioContext.cpp ('K') | « Source/modules/webaudio/AudioContext.cpp ('k') | Source/platform/audio/HRTFPanner.cpp » ('j') | Source/platform/audio/HRTFPanner.cpp » ('J')