Source/modules/webaudio/AudioContext.cpp - Issue 375383002: Extending supported sample rate from 3.0KHz to 192.0KHz for OfflineAudioContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/AudioContext.cpp

Issue 375383002: Extending supported sample rate from 3.0KHz to 192.0KHz for OfflineAudioContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update layoutTest Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/webaudio/offlineaudiocontext-constructor.html ('K') | « LayoutTests/webaudio/offlineaudiocontext-constructor-expected.txt ('k') | Source/modules/webaudio/OfflineAudioContext.cpp » ('j') | Source/modules/webaudio/OfflineAudioContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/AudioContext.cpp

diff --git a/Source/modules/webaudio/AudioContext.cpp b/Source/modules/webaudio/AudioContext.cpp

index 6e4ddf65add102016812c4947f32b902ee144636..053e1254cefcd7d42efade6570359bc555d4671b 100644

--- a/Source/modules/webaudio/AudioContext.cpp

+++ b/Source/modules/webaudio/AudioContext.cpp

@@ -80,9 +80,7 @@ namespace WebCore {

bool AudioContext::isSampleRateRangeGood(float sampleRate)

{

- // FIXME: It would be nice if the minimum sample-rate could be less than 44.1KHz,

- // but that will require some fixes in HRTFPanner::fftSizeForSampleRate(), and some testing there.

- return sampleRate >= 44100 && sampleRate <= 96000;

+ return sampleRate >= 8000 && sampleRate <= 96000;

Raymond Toy 2014/07/30 16:49:38 AudioBuffers support sample rates from 3kHz to 192

KhNo 2014/07/31 16:45:53 I think there is no reason we should hesitate to e

Raymond Toy 2014/07/31 17:25:13 Great. Then you can use AudioBuffer::minSampleRate

}

// Don't allow more than this number of simultaneous AudioContexts talking to hardware.