Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: LayoutTests/webaudio/offlineaudiocontext-constructor.html

Issue 375383002: Extending supported sample rate from 3.0KHz to 192.0KHz for OfflineAudioContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update layoutTest Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/webaudio/offlineaudiocontext-constructor.html
diff --git a/LayoutTests/webaudio/offlineaudiocontext-constructor.html b/LayoutTests/webaudio/offlineaudiocontext-constructor.html
index a3d3f7147b7abdb0dc32385014e437cfa8e5aa87..a406e286c532d73da36e11f1c70b41c0a02003b6 100644
--- a/LayoutTests/webaudio/offlineaudiocontext-constructor.html
+++ b/LayoutTests/webaudio/offlineaudiocontext-constructor.html
@@ -10,6 +10,17 @@ description("Tests the OfflineAudioContext constructor");
// Make sure we don't crash when giving 0 as number of frames.
shouldThrow("new OfflineAudioContext(1, 0, 44100)");
+// Make sure throwing exception about out of sample rate range.
+shouldThrow("new OfflineAudioContext(2, 512, 4000)");
+shouldThrow("new OfflineAudioContext(2, 512, 98000)");
Raymond Toy 2014/07/30 16:49:38 Aren't these two tests already covered in dom-exce
KhNo 2014/07/31 16:45:53 Yes, it can be replaced. I think it doesn't need t
+// Make sure we don't throw exception supported ranges of sample rate.
+shouldNotThrow("new OfflineAudioContext(2, 512, 8000)");
+shouldNotThrow("new OfflineAudioContext(2, 512, 11025)");
+shouldNotThrow("new OfflineAudioContext(2, 512, 22050)");
+shouldNotThrow("new OfflineAudioContext(2, 512, 44100)");
+shouldNotThrow("new OfflineAudioContext(2, 512, 88200)");
+shouldNotThrow("new OfflineAudioContext(2, 512, 96000)");
Raymond Toy 2014/07/30 16:49:38 Might as well add a test for 48000, which is anoth
KhNo 2014/07/31 16:45:53 I agree with you, if there are famous values shoul
Raymond Toy 2014/07/31 17:25:13 Just 48000 is enough for me.
+
</script>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698