Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Unified Diff: Source/modules/geolocation/CircularRegion.idl

Issue 375353002: Add the first very basic bits of a geofencing API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: address comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/geolocation/CircularRegion.idl
diff --git a/Source/modules/geolocation/CircularRegion.idl b/Source/modules/geolocation/CircularRegion.idl
new file mode 100644
index 0000000000000000000000000000000000000000..bc8ce0b45e73475607117f8a1421339ad0f2a2af
--- /dev/null
+++ b/Source/modules/geolocation/CircularRegion.idl
@@ -0,0 +1,16 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+[
+ RuntimeEnabled=Geofencing,
+ GarbageCollected,
+ Constructor(Dictionary init)
Peter Beverloo 2014/07/10 13:17:28 What is the expected behavior of the following? v
Marijn Kruisselbrink 2014/07/10 15:11:01 I don't think a CircularRegion without at least a
Peter Beverloo 2014/07/10 16:31:36 What else do you imagine to be required for a circ
Marijn Kruisselbrink 2014/07/11 10:06:39 Yes, I agree that this isn't the place to discuss
+] interface CircularRegion : GeofencingRegion {
+ const double MIN_RADIUS = 1.0;
Peter Beverloo 2014/07/10 13:17:27 I share Jochen's concern that this isn't clear wit
Marijn Kruisselbrink 2014/07/10 15:11:01 I agree that it isn't immediately clear what unit
+ const double MAX_RADIUS = 100.0;
+
+ readonly attribute double latitude;
+ readonly attribute double longitude;
+ readonly attribute double radius;
+};

Powered by Google App Engine
This is Rietveld 408576698