Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: Source/modules/geolocation/CircularRegion.idl

Issue 375353002: Add the first very basic bits of a geofencing API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: address comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 [
6 RuntimeEnabled=Geofencing,
7 GarbageCollected,
8 Constructor(Dictionary init)
Peter Beverloo 2014/07/10 13:17:28 What is the expected behavior of the following? v
Marijn Kruisselbrink 2014/07/10 15:11:01 I don't think a CircularRegion without at least a
Peter Beverloo 2014/07/10 16:31:36 What else do you imagine to be required for a circ
Marijn Kruisselbrink 2014/07/11 10:06:39 Yes, I agree that this isn't the place to discuss
9 ] interface CircularRegion : GeofencingRegion {
10 const double MIN_RADIUS = 1.0;
Peter Beverloo 2014/07/10 13:17:27 I share Jochen's concern that this isn't clear wit
Marijn Kruisselbrink 2014/07/10 15:11:01 I agree that it isn't immediately clear what unit
11 const double MAX_RADIUS = 100.0;
12
13 readonly attribute double latitude;
14 readonly attribute double longitude;
15 readonly attribute double radius;
16 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698