Issue 375213003: Node.appendChild should throw TypeError when newChild is omitted

Issue 375213003: Node.appendChild should throw TypeError when newChild is omitted (Closed)

Created:
6 years, 5 months ago by kangil_

Modified:
6 years, 5 months ago

Reviewers:
tkent, haraken

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, blink-reviews-bindings_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Node.appendChild should throw TypeError when newChild is omitted This is a follow-up CL of https://codereview.chromium.org/374093002/ TEST=LayoutTests/fast/dom/Node/append-child-error.html ,LayoutTests/fast/inspector-support/uncaught-dom8-exception.html ,LayoutTests/fast/js/dot-node-base-exception.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177738

Patch Set 1 #

Total comments: 6

Patch Set 2 : Take review comment into consideration #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -4 lines)			Patch
A	LayoutTests/fast/dom/Node/append-child-error.html	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/Node/append-child-error-expected.txt	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/inspector-support/uncaught-dom8-exception-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/js/dot-node-base-exception-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/js/script-tests/dot-node-base-exception.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/core/v8/custom/V8NodeCustom.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/375213003/diff/1/LayoutTests/fast/dom/Node/append-child-error.html File LayoutTests/fast/dom/Node/append-child-error.html (right): https://codereview.chromium.org/375213003/diff/1/LayoutTests/fast/dom/Node/append-child-error.html#newcode4 LayoutTests/fast/dom/Node/append-child-error.html:4: <title>Node.appendChild TypeError</title> Remove this. https://codereview.chromium.org/375213003/diff/1/LayoutTests/fast/dom/Node/append-child-error.html#newcode7 LayoutTests/fast/dom/Node/append-child-error.html:7: <div id="log"></div> ...

6 years, 5 months ago (2014-07-09 08:31:10 UTC) #2

kangil_

https://codereview.chromium.org/375213003/diff/1/LayoutTests/fast/dom/Node/append-child-error.html File LayoutTests/fast/dom/Node/append-child-error.html (right): https://codereview.chromium.org/375213003/diff/1/LayoutTests/fast/dom/Node/append-child-error.html#newcode4 LayoutTests/fast/dom/Node/append-child-error.html:4: <title>Node.appendChild TypeError</title> On 2014/07/09 08:31:10, haraken wrote: > > ...

6 years, 5 months ago (2014-07-09 08:36:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/375213003/20001

6 years, 5 months ago (2014-07-09 08:36:51 UTC) #5

Message was sent while issue was closed.

Change committed as 177738

Expand Messages | Collapse Messages