Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: LayoutTests/fast/js/script-tests/dot-node-base-exception.js

Issue 375213003: Node.appendChild should throw TypeError when newChild is omitted (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take review comment into consideration Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/js/script-tests/dot-node-base-exception.js
diff --git a/LayoutTests/fast/js/script-tests/dot-node-base-exception.js b/LayoutTests/fast/js/script-tests/dot-node-base-exception.js
index 201e0a9b04fc41acb3b315cc766799078b26485b..2035bbac88dd03cbf44da4fefb05c52b01a14711 100644
--- a/LayoutTests/fast/js/script-tests/dot-node-base-exception.js
+++ b/LayoutTests/fast/js/script-tests/dot-node-base-exception.js
@@ -2,5 +2,5 @@ description(
"This test checks that a correct exception is raised when calculating the base value of a dot expression fails."
);
-// Should be a DOM exception, not just some "TypeError: Null value".
-shouldThrow('(document.appendChild()).foobar()', '"NotFoundError: Failed to execute \'appendChild\' on \'Node\': The new child element is null."');
+// Should throw TypeError with appropriate message.
+shouldThrow('(document.appendChild()).foobar()', '"TypeError: Failed to execute \'appendChild\' on \'Node\': 1 argument required, but only 0 present."');
« no previous file with comments | « LayoutTests/fast/js/dot-node-base-exception-expected.txt ('k') | Source/bindings/core/v8/custom/V8NodeCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698