[SyncFS] Expose constants in SyncProcessRunner

chrome/browser/sync_file_system/sync_process_runner.cc

Index: chrome/browser/sync_file_system/sync_process_runner.cc
diff --git a/chrome/browser/sync_file_system/sync_process_runner.cc b/chrome/browser/sync_file_system/sync_process_runner.cc
index d7c71cecdd5649859cb6c03cd7f7d3234d44b204..76ab0708efdc0bf01d6ec6e1cef8e837c3496f79 100644
--- a/chrome/browser/sync_file_system/sync_process_runner.cc
+++ b/chrome/browser/sync_file_system/sync_process_runner.cc
@@ -9,27 +9,19 @@
 
 namespace sync_file_system {
 
-namespace {
-
-// Default delay when more changes are available.
-const int64 kSyncDelayInMilliseconds = 1 * base::Time::kMillisecondsPerSecond;
-
-// Default delay when the previous change has had an error (but remote service
-// is running).
-const int64 kSyncDelayWithSyncError = 3 * base::Time::kMillisecondsPerSecond;
-
-// Default delay when there're more than 10 pending changes.
-const int64 kSyncDelayFastInMilliseconds = 100;
-const int kPendingChangeThresholdForFastSync = 10;
-
-// Default delay when remote service is temporarily unavailable.
-const int64 kSyncDelaySlowInMilliseconds =
+const int64 SyncProcessRunner::kSyncDelayInMilliseconds =
+    1 * base::Time::kMillisecondsPerSecond;

[peria, 2014/07/09 06:24:28]

Could you add a comment to show this value figures "1 sec.",
like kSyncDelayMaxInMilliseconds?

[tzik, 2014/07/09 06:48:00]

Done.

+const int64 SyncProcessRunner::kSyncDelayWithSyncError =
+    3 * base::Time::kMillisecondsPerSecond;

[peria, 2014/07/09 06:24:28]

ditto

[tzik, 2014/07/09 06:48:00]

Done.

+const int64 SyncProcessRunner::kSyncDelayFastInMilliseconds = 100;
+const int SyncProcessRunner::kPendingChangeThresholdForFastSync = 10;
+const int64 SyncProcessRunner::kSyncDelaySlowInMilliseconds =
     30 * base::Time::kMillisecondsPerSecond;  // Start with 30 sec + exp backoff

[peria, 2014/07/09 06:24:28]

This comment seems strange, because the value is const.
Comments for usage are good to put on .h file or the place where they are used.

[tzik, 2014/07/09 06:48:00]

Done.

-
-// Default delay when there're no changes.
-const int64 kSyncDelayMaxInMilliseconds =
+const int64 SyncProcessRunner::kSyncDelayMaxInMilliseconds =
     30 * 60 * base::Time::kMillisecondsPerSecond;  // 30 min
 
+namespace {
+
 class BaseTimerHelper : public SyncProcessRunner::TimerHelper {
  public:
   BaseTimerHelper() {}