[SyncFS] Expose constants in SyncProcessRunner

chrome/browser/sync_file_system/sync_process_runner.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync_file_system/sync_process_runner.h"
 
 #include "base/format_macros.h"
 #include "chrome/browser/sync_file_system/logger.h"
 
 namespace sync_file_system {
 
+const int64 SyncProcessRunner::kSyncDelayInMilliseconds =
+    1 * base::Time::kMillisecondsPerSecond;

[peria, 2014/07/09 06:24:28]

Could you add a comment to show this value figures "1 sec.",
like kSyncDelayMaxInMilliseconds?

[tzik, 2014/07/09 06:48:00]

Done.

+const int64 SyncProcessRunner::kSyncDelayWithSyncError =
+    3 * base::Time::kMillisecondsPerSecond;

[peria, 2014/07/09 06:24:28]

ditto

[tzik, 2014/07/09 06:48:00]

Done.

+const int64 SyncProcessRunner::kSyncDelayFastInMilliseconds = 100;
+const int SyncProcessRunner::kPendingChangeThresholdForFastSync = 10;
+const int64 SyncProcessRunner::kSyncDelaySlowInMilliseconds =
+    30 * base::Time::kMillisecondsPerSecond;  // Start with 30 sec + exp backoff

[peria, 2014/07/09 06:24:28]

This comment seems strange, because the value is const.
Comments for usage are good to put on .h file or the place where they are used.

[tzik, 2014/07/09 06:48:00]

Done.

+const int64 SyncProcessRunner::kSyncDelayMaxInMilliseconds =
+    30 * 60 * base::Time::kMillisecondsPerSecond;  // 30 min
+
 namespace {
 
-// Default delay when more changes are available.
-const int64 kSyncDelayInMilliseconds = 1 * base::Time::kMillisecondsPerSecond;
-
-// Default delay when the previous change has had an error (but remote service
-// is running).
-const int64 kSyncDelayWithSyncError = 3 * base::Time::kMillisecondsPerSecond;
-
-// Default delay when there're more than 10 pending changes.
-const int64 kSyncDelayFastInMilliseconds = 100;
-const int kPendingChangeThresholdForFastSync = 10;
-
-// Default delay when remote service is temporarily unavailable.
-const int64 kSyncDelaySlowInMilliseconds =
-    30 * base::Time::kMillisecondsPerSecond;  // Start with 30 sec + exp backoff
-
-// Default delay when there're no changes.
-const int64 kSyncDelayMaxInMilliseconds =
-    30 * 60 * base::Time::kMillisecondsPerSecond;  // 30 min
-
 class BaseTimerHelper : public SyncProcessRunner::TimerHelper {
  public:
   BaseTimerHelper() {}
 
   virtual bool IsRunning() OVERRIDE {
     return timer_.IsRunning();
   }
 
   virtual void Start(const tracked_objects::Location& from_here,
                      const base::TimeDelta& delay,
@@ skipping 157 matching lines @@
               name_.c_str(), time_to_next.InSeconds());
   }
   current_delay_ = delay;
 
   timer_helper_->Start(
       FROM_HERE, time_to_next,
       base::Bind(&SyncProcessRunner::Run, base::Unretained(this)));
 }
 
 }  // namespace sync_file_system