[SyncFS] Expose constants in SyncProcessRunner

[SyncFS] Expose constants in SyncProcessRunner

Expose SyncProcessRunner's constants to use it in the test code.

BUG=344769
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282002

[tzik, 2014-07-09 06:15:20]

PTL

[peria, 2014-07-09 06:24:28]

LGTM with nits.

https://codereview.chromium.org/375123003/diff/20001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/sync_process_runner.cc (right):

https://codereview.chromium.org/375123003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/sync_process_runner.cc:13: 1 *
base::Time::kMillisecondsPerSecond;
Could you add a comment to show this value figures "1 sec.",
like kSyncDelayMaxInMilliseconds?

https://codereview.chromium.org/375123003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/sync_process_runner.cc:15: 3 *
base::Time::kMillisecondsPerSecond;
ditto

https://codereview.chromium.org/375123003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/sync_process_runner.cc:19: 30 *
base::Time::kMillisecondsPerSecond;  // Start with 30 sec + exp backoff
This comment seems strange, because the value is const.
Comments for usage are good to put on .h file or the place where they are used.

[tzik, 2014-07-09 06:48:00]

https://codereview.chromium.org/375123003/diff/20001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/sync_process_runner.cc (right):

https://codereview.chromium.org/375123003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/sync_process_runner.cc:13: 1 *
base::Time::kMillisecondsPerSecond;
On 2014/07/09 06:24:28, peria wrote:
> Could you add a comment to show this value figures "1 sec.",
> like kSyncDelayMaxInMilliseconds?

Done.

https://codereview.chromium.org/375123003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/sync_process_runner.cc:15: 3 *
base::Time::kMillisecondsPerSecond;
On 2014/07/09 06:24:28, peria wrote:
> ditto

Done.

https://codereview.chromium.org/375123003/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/sync_process_runner.cc:19: 30 *
base::Time::kMillisecondsPerSecond;  // Start with 30 sec + exp backoff
On 2014/07/09 06:24:28, peria wrote:
> This comment seems strange, because the value is const.
> Comments for usage are good to put on .h file or the place where they are
used.

Done.

[tzik, 2014-07-09 06:48:07]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-07-09 06:48:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/375123003/40001

[commit-bot: I haz the power, 2014-07-09 09:01:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-09 10:48:46]

Change committed as 282002