Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1861)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 375093002: Initial attempt at counting layers in the compositor thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use LayerTreeImpl::layer_id_map_.size() and fix histogram name Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/trees/layer_tree_impl.h » ('j') | cc/trees/layer_tree_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index c3738e594734e6b5fd7df5d2fe9e6ca0191ba22e..862f806b741ef8ff3cb62d40da0cf0cf35f3d0a3 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -1101,6 +1101,11 @@ DrawResult LayerTreeHostImpl::PrepareToDraw(FrameData* frame) {
}
need_to_update_visible_tiles_before_draw_ = true;
+ // Use a bucket width of 10 (i.e. 1000/100) to better
danakj 2014/07/10 21:27:44 I'm not sure what this comment is saying? That you
dneto 2014/07/11 15:23:30 The 1 is min, the 1000 is max, and 10 is the numbe
danakj 2014/07/11 15:27:20 Ok how about 1, 400, 20? And we can drop the comme
+ // capture the expected case where there are few layers.
+ UMA_HISTOGRAM_CUSTOM_COUNTS(
+ "Compositing.NumActiveLayers", active_tree_->NumLayers(), 1, 1000, 100);
dneto 2014/07/10 21:20:11 This is the corrected name for the UMA, matching t
+
bool ok = active_tree_->UpdateDrawProperties();
DCHECK(ok) << "UpdateDrawProperties failed during draw";
« no previous file with comments | « no previous file | cc/trees/layer_tree_impl.h » ('j') | cc/trees/layer_tree_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698