Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 374883004: Revert of Blink does not respect input.selectionStart and input.selectionEnd for some cases (Closed)

Created:
6 years, 5 months ago by Peter Beverloo
Modified:
6 years, 5 months ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org, ojan
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Blink does not respect input.selectionStart and input.selectionEnd for some cases (https://codereview.chromium.org/258063005/) Reason for revert: Suspected of breaking browser_tests on various platforms: * ClearPreviewWithAutofilledUsernameAndPassword * ClearPreviewWithUsernameAutofilled * PreviewSuggestionSelectionRange [PasswordAutofillAgentTest.ClearPreviewWithUsernameAutofilled] * Value of: username_element_.selectionStart() * Actual: 0 (expected: |start|, which is: 3) Logs are available here: * http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/3108/steps/browser_tests/logs/stdio NOTRY=true TBR=tkent Original issue's description: > Blink does not respect input.selectionStart and input.selectionEnd for some cases > > Blink does not respect the input.selectionStart and input.selectionEnd. When > input.selectionStart and input.selectionEnd is set and then value is set the blink > always shows the selection with caret at end of text. This patch removes this > bug by caching the selectionStart and selectionEnd in m_cachedSelectionStart > and m_cachedSelectionEnd and checking the cached selection while setting > input value. > > This patch also removes the bug specifying that caret poistion is incompatible after updating value > IDL attribute of unfocused INPUT element. When the value IDL attribute is updated of unfocused > INPUT element the caret moves at the end but other browser move the caret at the beginning of the value. > The other browsers move the caret to the end of the value only if the INPUT is focused. > This patch removes this bug too. > > BUG=367736, 133242 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177651 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -83 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/accessibility/textarea-insertion-point-line-number.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/accessibility/textarea-insertion-point-line-number-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/deleting/5290534.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/inserting/4960120-1.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/pasteboard/paste-removing-iframe.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/editing/pasteboard/pasting-tabs.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/selection/5497643.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/input-placeholder-visibility-2-expected.html View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/forms/input-set-selectionStart-set-selectionEnd.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/fast/forms/input-set-selectionStart-set-selectionEnd-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
M LayoutTests/fast/forms/input-setvalue-selection.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/paste-into-textarea.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/textarea-arrow-navigation.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/validationMessage.html View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 3 chunks +11 lines, -18 lines 0 comments Download
M Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Peter Beverloo
Created Revert of Blink does not respect input.selectionStart and input.selectionEnd for some cases
6 years, 5 months ago (2014-07-08 13:17:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/374883004/1
6 years, 5 months ago (2014-07-08 13:18:51 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 13:18:51 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-08 13:18:52 UTC) #4
Peter Beverloo
On 2014/07/08 13:18:52, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 5 months ago (2014-07-08 13:20:09 UTC) #5
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 5 months ago (2014-07-08 13:20:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/374883004/1
6 years, 5 months ago (2014-07-08 13:21:29 UTC) #7
Peter Beverloo
The CQ bit was unchecked by peter@chromium.org
6 years, 5 months ago (2014-07-08 13:22:10 UTC) #8
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 5 months ago (2014-07-08 13:22:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/374883004/1
6 years, 5 months ago (2014-07-08 13:22:16 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 13:23:03 UTC) #11
Message was sent while issue was closed.
Change committed as 177668

Powered by Google App Engine
This is Rietveld 408576698