Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 374833006: Split SkPictureRangePlayback out of SkPicturePlayback (Closed)

Created:
6 years, 5 months ago by robertphillips
Modified:
6 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Split SkPictureRangePlayback out of SkPicturePlayback This CL starts cleaning up SkPicturePlayback. Future CLs will: split out the SkPictureReplacementPlayback remove the preDraw/postDraw entry points & fix up SkPictureTimedPlayback Committed: https://skia.googlesource.com/skia/+/1ad00e4b245d464c16ba78bdaa377281f29972cd

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed code review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -80 lines) Patch
M gyp/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPictureData.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPicturePlayback.h View 6 chunks +17 lines, -18 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 8 chunks +22 lines, -59 lines 0 comments Download
A src/core/SkPictureRangePlayback.h View 1 1 chunk +40 lines, -0 lines 0 comments Download
A src/core/SkPictureRangePlayback.cpp View 1 chunk +57 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
6 years, 5 months ago (2014-07-08 14:25:47 UTC) #1
mtklein
lgtm https://codereview.chromium.org/374833006/diff/1/src/core/SkPictureRangePlayback.h File src/core/SkPictureRangePlayback.h (right): https://codereview.chromium.org/374833006/diff/1/src/core/SkPictureRangePlayback.h#newcode33 src/core/SkPictureRangePlayback.h:33: void setDrawLimits(size_t start, size_t stop) { As used, ...
6 years, 5 months ago (2014-07-08 14:31:57 UTC) #2
robertphillips
https://codereview.chromium.org/374833006/diff/1/src/core/SkPictureRangePlayback.h File src/core/SkPictureRangePlayback.h (right): https://codereview.chromium.org/374833006/diff/1/src/core/SkPictureRangePlayback.h#newcode33 src/core/SkPictureRangePlayback.h:33: void setDrawLimits(size_t start, size_t stop) { On 2014/07/08 14:31:57, ...
6 years, 5 months ago (2014-07-08 14:38:33 UTC) #3
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 5 months ago (2014-07-08 15:12:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/374833006/20001
6 years, 5 months ago (2014-07-08 15:12:46 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 15:28:12 UTC) #6
Message was sent while issue was closed. 
Change committed as 1ad00e4b245d464c16ba78bdaa377281f29972cd

Powered by Google App Engine
This is Rietveld 408576698