Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: tools/clang/blink_gc_plugin/tests/heap/stubs.h

Issue 374593002: Support ignorance of base class finalizers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use early returns instead of fallthrough Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/tests/heap/stubs.h
diff --git a/tools/clang/blink_gc_plugin/tests/heap/stubs.h b/tools/clang/blink_gc_plugin/tests/heap/stubs.h
index a9e64f589276decbe1f013a38d575294ef60ca84..40ced37fa76d90eb95b3b96f18594a4e1ff38f48 100644
--- a/tools/clang/blink_gc_plugin/tests/heap/stubs.h
+++ b/tools/clang/blink_gc_plugin/tests/heap/stubs.h
@@ -218,6 +218,15 @@ class GarbageCollectedMixin {
virtual bool isAlive(Visitor*) const = 0;
};
+// WebCore::ScriptWrappable receives special treatment
+// so as to allow it to be used together with GarbageCollected<T>,
+// even when its user-declared destructor is provided.
+// As it is with Oilpan disabled.
+class ScriptWrappable {
+public:
+ ~ScriptWrappable() { /* user-declared, thus, non-trivial */ }
+};
+
}
namespace WTF {
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698