Revert 281908 "Revert of Remove disable-app-list-voice-search fl..."

Revert 281908 "Revert of Remove disable-app-list-voice-search fl..."

Revert reason:
- the change seems okay, the compile error is caused because
  the builder doesn't recomile about_flags. Clobber might fix the
  issue.
- this should be reverted again if it still causes the error
  after clobber.

> Revert of Remove disable-app-list-voice-search flag. (https://codereview.chromium.org/353793003/)
> 
> Reason for revert:
> Caused compile error on Blink GPU Mac Builder:
> http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder
> 
> Original issue's description:
> > Remove disable-app-list-voice-search flag.
> > 
> > BUG=367341
> > R=xiyuan@chromium.org
> > TEST=compile
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281904
> 
> TBR=xiyuan@chromium.org,mukai@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=367341
> 
> Review URL: https://codereview.chromium.org/379673003

TBR=yutak@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281923

[Jun Mukai, 2014-07-09 04:16:37]

Committed patchset #1 manually as r281923.

[Nico, 2014-07-09 04:20:11]

I'm pretty sure that our build rebuilds files that have been touched. Do you
have a link to a build where you think that didn't happen? That'd be a serious
build bug.

[Jun Mukai, 2014-07-09 04:24:17]

On 2014/07/09 04:20:11, Nico (away) wrote:
> I'm pretty sure that our build rebuilds files that have been touched. Do you
> have a link to a build where you think that didn't happen? That'd be a serious
> build bug.

See
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder/buil...
app_list_switches.cc is compiled but about_flags.cc is not on the log, and then
reporting a missing symbol in about_flags.o in libbrowser.a

[Nico, 2014-07-09 04:24:43]

On 2014/07/09 04:20:11, Nico (away) wrote:
> I'm pretty sure that our build rebuilds files that have been touched. Do you
> have a link to a build where you think that didn't happen? That'd be a serious
> build bug.

…http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder/builds/15846
is an example. about_flags.cc was patched in that change, but not rebuilt!

[Nico, 2014-07-09 04:26:54]

On 2014/07/09 04:24:43, Nico (away) wrote:
> On 2014/07/09 04:20:11, Nico (away) wrote:
> > I'm pretty sure that our build rebuilds files that have been touched. Do you
> > have a link to a build where you think that didn't happen? That'd be a
serious
> > build bug.
> 
>
…http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder/builds/15846
> is an example. about_flags.cc was patched in that change, but not rebuilt!

Oh, you just said that. This is very troubling :-( I filed
https://code.google.com/p/chromium/issues/detail?id=392367

[Jun Mukai, 2014-07-09 04:27:47]

On 2014/07/09 04:26:54, Nico (away) wrote:
> On 2014/07/09 04:24:43, Nico (away) wrote:
> > On 2014/07/09 04:20:11, Nico (away) wrote:
> > > I'm pretty sure that our build rebuilds files that have been touched. Do
you
> > > have a link to a build where you think that didn't happen? That'd be a
> serious
> > > build bug.
> > 
> >
>
…http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder/builds/15846
> > is an example. about_flags.cc was patched in that change, but not rebuilt!
> 
> Oh, you just said that. This is very troubling :-( I filed
> https://code.google.com/p/chromium/issues/detail?id=392367

thanks for filing!