Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 379673003: Revert of Remove disable-app-list-voice-search flag. (Closed)

Created:
6 years, 5 months ago by Yuta Kitamura
Modified:
6 years, 5 months ago
Reviewers:
xiyuan, Jun Mukai
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

Revert of Remove disable-app-list-voice-search flag. (https://codereview.chromium.org/353793003/) Reason for revert: Caused compile error on Blink GPU Mac Builder: http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder Original issue's description: > Remove disable-app-list-voice-search flag. > > BUG=367341 > R=xiyuan@chromium.org > TEST=compile > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281904 TBR=xiyuan@chromium.org,mukai@chromium.org NOTREECHECKS=true NOTRY=true BUG=367341 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/app_list/app_list_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/app_list_switches.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yuta Kitamura
Created Revert of Remove disable-app-list-voice-search flag.
6 years, 5 months ago (2014-07-09 01:41:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yutak@chromium.org/379673003/1
6 years, 5 months ago (2014-07-09 01:43:21 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 01:45:37 UTC) #3
Message was sent while issue was closed.
Change committed as 281908

Powered by Google App Engine
This is Rietveld 408576698