Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 374243004: Eliminate the dependence of tts extension API form tts_controller.cc (Closed)

Created:
6 years, 5 months ago by gaochun
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Eliminate the dependence of tts extension API form tts_controller.cc This is the first patch to move TTS implementation from browser layer to content. To move TTS to conent, the direct dependence of browser compoent should be eliminated from TTS classes first. BUG=347045 R=tommi@chromium.org, dmazzoni@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282813

Patch Set 1 #

Patch Set 2 : Fix compile issue for mac #

Patch Set 3 : Skip the instantiation of TtsExtensionEngine for android. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -44 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_engine_extension_api.h View 1 1 chunk +13 lines, -26 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_engine_extension_api.cc View 5 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/speech/tts_controller.h View 3 chunks +30 lines, -0 lines 0 comments Download
M chrome/browser/speech/tts_controller.cc View 9 chunks +20 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
gaochun
This is a fix for the reverted commit https://codereview.chromium.org/181123004 https://codereview.chromium.org/188633003/
6 years, 5 months ago (2014-07-09 07:01:33 UTC) #1
dmazzoni
lgtm
6 years, 5 months ago (2014-07-09 15:14:39 UTC) #2
tommi (sloooow) - chröme
lgtm
6 years, 5 months ago (2014-07-09 15:32:13 UTC) #3
dmazzoni
Looks like a few compile errors on some platforms: In file included from ../../chrome/browser/chrome_content_browser_client.cc:73: ../../chrome/browser/speech/extension_api/tts_engine_extension_api.h:37:3:error: ...
6 years, 5 months ago (2014-07-09 17:37:18 UTC) #4
gaochun
On 2014/07/09 17:37:18, dmazzoni wrote: > Looks like a few compile errors on some platforms: ...
6 years, 5 months ago (2014-07-10 01:34:55 UTC) #5
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 5 months ago (2014-07-10 15:37:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chun.gao@intel.com/374243004/20001
6 years, 5 months ago (2014-07-10 15:39:12 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 17:09:13 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 17:21:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/204714)
6 years, 5 months ago (2014-07-10 17:21:24 UTC) #10
gaochun
Please try build-bot again, thanks.
6 years, 5 months ago (2014-07-12 03:22:40 UTC) #11
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 5 months ago (2014-07-12 05:56:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chun.gao@intel.com/374243004/40001
6 years, 5 months ago (2014-07-12 05:57:11 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 12:44:15 UTC) #14
Message was sent while issue was closed.
Change committed as 282813

Powered by Google App Engine
This is Rietveld 408576698