Eliminate the dependence of tts extension API for tts_controller.cc

Eliminate the dependence of tts extension API for tts_controller.cc

This is the first patch to move TTS implementation from browser layer
to content. To move TTS to conent, the direct dependence of browser
compoent should be eliminated from TTS classes first.

R=tommi@chromium.org, dmazzoni@chromium.org, sky@chromium.org
BUG=347045
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254740

[gaochun, 2014-02-27 01:47:50]

The CQ bit was checked by chun.gao@intel.com

[gaochun, 2014-02-27 01:47:51]

The CQ bit was unchecked by chun.gao@intel.com

[gaochun, 2014-02-27 01:47:52]

The CQ bit was checked by chun.gao@intel.com

[gaochun, 2014-02-27 01:47:53]

The CQ bit was unchecked by chun.gao@intel.com

[gaochun, 2014-02-27 02:17:04]

As discussed at
https://groups.google.com/a/chromium.org/forum/#!mydiscussions/chromium-dev/8...
I upload this patch for the first step of moving TTS implementation to content.

Please review, thanks.

[dmazzoni, 2014-02-27 16:16:39]

Overall this looks pretty good, thanks! I think your change is out of date, the
code review system was unable to do a diff. Please rebase and then address
just a few comments:

https://codereview.chromium.org/181123004/diff/20001/chrome/browser/speech/ex...
File chrome/browser/speech/extension_api/tts_engine_extension_api.h (right):

https://codereview.chromium.org/181123004/diff/20001/chrome/browser/speech/ex...
chrome/browser/speech/extension_api/tts_engine_extension_api.h:35: 
Nit: for the most part we don't add comments to overrides from an abstract base
class.. Add a comment if you need to add detail that the base class didn't
document, otherwise this just becomes redundant (and risks going stale).

https://codereview.chromium.org/181123004/diff/20001/chrome/browser/speech/tt...
File chrome/browser/speech/tts_controller.h (right):

https://codereview.chromium.org/181123004/diff/20001/chrome/browser/speech/tt...
chrome/browser/speech/tts_controller.h:80: 
I'd phrase this differently - note that we have the tts platform implementation
system also, which also "processes the actual TTS actions". The TTS Engine
Delegate is the system that delegates TTS requests to user-installed plug-ins,
as opposed to something built into the operating system.

https://codereview.chromium.org/181123004/diff/20001/chrome/browser/speech/tt...
chrome/browser/speech/tts_controller.h:87: 
I think these should be pure virtual.

https://codereview.chromium.org/181123004/diff/20001/chrome/browser/speech/tt...
chrome/browser/speech/tts_controller.h:323: 
Adjust this based on comment above

[gaochun, 2014-02-28 06:35:23]

Also add browser.cc owner sky@chromium.org to reviewer list, thanks.

[gaochun, 2014-02-28 06:36:02]

On 2014/02/27 16:16:39, dmazzoni wrote:
> Overall this looks pretty good, thanks! I think your change is out of date,
the
> code review system was unable to do a diff. Please rebase and then address
> just a few comments:
> 
>
https://codereview.chromium.org/181123004/diff/20001/chrome/browser/speech/ex...
> File chrome/browser/speech/extension_api/tts_engine_extension_api.h (right):
> 
>
https://codereview.chromium.org/181123004/diff/20001/chrome/browser/speech/ex...
> chrome/browser/speech/extension_api/tts_engine_extension_api.h:35: 
> Nit: for the most part we don't add comments to overrides from an abstract
base
> class.. Add a comment if you need to add detail that the base class didn't
> document, otherwise this just becomes redundant (and risks going stale).
> 
>
https://codereview.chromium.org/181123004/diff/20001/chrome/browser/speech/tt...
> File chrome/browser/speech/tts_controller.h (right):
> 
>
https://codereview.chromium.org/181123004/diff/20001/chrome/browser/speech/tt...
> chrome/browser/speech/tts_controller.h:80: 
> I'd phrase this differently - note that we have the tts platform
implementation
> system also, which also "processes the actual TTS actions". The TTS Engine
> Delegate is the system that delegates TTS requests to user-installed plug-ins,
> as opposed to something built into the operating system.
> 
>
https://codereview.chromium.org/181123004/diff/20001/chrome/browser/speech/tt...
> chrome/browser/speech/tts_controller.h:87: 
> I think these should be pure virtual.
> 
>
https://codereview.chromium.org/181123004/diff/20001/chrome/browser/speech/tt...
> chrome/browser/speech/tts_controller.h:323: 
> Adjust this based on comment above

Patch was updated, please review again, thanks.

[dmazzoni, 2014-02-28 08:07:18]

lgtm

I'll start try jobs for you. Please look at any compile failures or test
failures and make sure they're not related.

[sky, 2014-02-28 15:01:22]

browser LGTM

[gaochun, 2014-03-01 04:49:31]

On 2014/02/28 08:07:18, dmazzoni wrote:
> lgtm
> 
> I'll start try jobs for you. Please look at any compile failures or test
> failures and make sure they're not related.

The patch did not cause any build issue and block any test.

[dmazzoni, 2014-03-02 06:42:27]

On 2014/03/01 04:49:31, gaochun wrote:
> On 2014/02/28 08:07:18, dmazzoni wrote:
> > lgtm
> > 
> > I'll start try jobs for you. Please look at any compile failures or test
> > failures and make sure they're not related.
> 
> The patch did not cause any build issue and block any test.

Looks to me like it doesn't compile on Mac:

FAILED: clang++ -MMD -MF obj/chrome/browser/ui/browser_ui.browser.o.d
-DV8_DEPRECATION_WARNINGS -DCHROMIUM_BUILD -DCOMPONENT_BUILD
-DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1
-DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY
-DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
-DENABLE_NEW_GAMEPAD_API=1 -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY
-DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDCHECK_ALWAYS_ON=1
-DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
-DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1
-DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2
-DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1
-DENABLE_MANAGED_USERS=1 -DNACL_WINDOWS=0 -DNACL_LINUX=0 -DNACL_OSX=1
-DNACL_TARGET_SUBARCH=32 -DNACL_TARGET_ARCH=x86 -DNACL_BUILD_SUBARCH=32
-DNACL_BUILD_ARCH=x86 -DFULL_SAFE_BROWSING -DGTEST_HAS_POSIX_RE=0
-DLIBPEERCONNECTION_LIB=1 -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI
-DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DPASSWORD_MANAGER_ENABLE_SYNC
-DNO_NSPR_10_SUPPORT -DNSS_ENABLE_ECC -DNSS_STATIC -DNSS_USE_STATIC_LIBS
-DUSE_UTIL_DIRECTLY -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0
-DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1
'-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
-DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1
-DSK_SUPPORT_LEGACY_LAYERRASTERIZER_API=1 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT
-DSK_SUPPORT_LEGACY_COMPATIBLEDEVICE_CONFIG=1
-DSK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS=1 -DSK_SUPPORT_LEGACY_COPYTO_CONFIG
-DSK_SUPPORT_DEEPCOPYTO_CONFIG -DSK_USE_POSIX_THREADS
-DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DU_USING_ICU_NAMESPACE=0 -DLIBXML_STATIC
-DXML_STATIC -DHUNSPELL_STATIC -DHUNSPELL_CHROME_CLIENT -DUSE_HUNSPELL
-DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH
-DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DOSX -DPOSIX
-DV8_SHARED -DUSING_V8_SHARED -DUSE_CUPS
'-DCUSTOM_BASICTYPES="base/basictypes.h"'
'-DCUSTOM_SCOPED_PTR="base/memory/scoped_ptr.h"' -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -I../.. -Iobj/chrome/browser_ui.gen
-Igen -I../../skia/config -I../../third_party/khronos -I../../gpu
-I../../third_party/WebKit/Source -Igen/protoc_out -I../../third_party/protobuf
-I../../third_party/protobuf/src -Igen/chrome -Igen/components/strings
-I../../third_party/nss/nspr/pr/include -I../../third_party/nss/nspr/lib/ds
-I../../third_party/nss/nspr/lib/libc/include
-I../../third_party/nss/nss/lib/base -I../../third_party/nss/nss/lib/certdb
-I../../third_party/nss/nss/lib/certhigh
-I../../third_party/nss/nss/lib/cryptohi -I../../third_party/nss/nss/lib/dev
-I../../third_party/nss/nss/lib/freebl
-I../../third_party/nss/nss/lib/freebl/ecl -I../../third_party/nss/nss/lib/nss
-I../../third_party/nss/nss/lib/pk11wrap -I../../third_party/nss/nss/lib/pkcs7
-I../../third_party/nss/nss/lib/pki -I../../third_party/nss/nss/lib/smime
-I../../third_party/nss/nss/lib/softoken -I../../third_party/nss/nss/lib/util
-I../../third_party/skia/src/core -I../../third_party/skia/include/core
-I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf
-I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy
-I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe
-I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
-I../../skia/ext -I../../third_party/skia/include/utils/mac
-I../../third_party/cacheinvalidation/overrides
-I../../third_party/cacheinvalidation/src
-I../../third_party/cacheinvalidation/google/cacheinvalidation
-I../../third_party/icu/source/i18n -I../../third_party/icu/source/common
-I../../third_party/libusb/src/libusb -I../../third_party/libxml/mac/include
-I../../third_party/libxml/src/include -I../../third_party/zlib
-Igen/ui/app_locale_settings -Igen/ui/ui_strings -Igen/ui/ui_resources
-I../../third_party/re2 -I../../third_party/expat/files/lib
-I../../third_party/leveldatabase/src/include
-I../../third_party/leveldatabase/src -I../../third_party/leveldatabase
-I../../third_party/libjingle/overrides -I../../third_party/libjingle/source
-I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc
-I../../third_party/npapi -I../../third_party/npapi/bindings -I../../v8/include
-Igen/webkit -Igen/policy -I../../third_party/google_toolbox_for_mac
-I../../third_party/google_toolbox_for_mac/src
-I../../third_party/google_toolbox_for_mac/src/AppKit
-I../../third_party/google_toolbox_for_mac/src/DebugUtils
-I../../third_party/google_toolbox_for_mac/src/Foundation
-I../../third_party/libaddressinput/chromium/cpp/include
-Igen/third_party/libaddressinput/ -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk
-O0 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch
i386 -Wall -Wendif-labels -Wextra -Wno-unused-parameter
-Wno-missing-field-initializers -Wheader-hygiene -Wno-c++11-narrowing
-Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-deprecated-register
-Wexit-time-destructors -std=gnu++11 -fno-rtti -fno-exceptions
-fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang
/Volumes/data/b/build/slave/mac/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics
-fno-strict-aliasing -fstack-protector-all  -c
../../chrome/browser/ui/browser.cc -o obj/chrome/browser/ui/browser_ui.browser.o
In file included from ../../chrome/browser/ui/browser.cc:80:
../../chrome/browser/speech/extension_api/tts_engine_extension_api.h:37:3:error:
[chromium-style] Overriding method must have "virtual" keyword.
  void GetVoices(Profile* profile,
  ^
  virtual

[gaochun, 2014-03-03 02:26:56]

On 2014/03/02 06:42:27, dmazzoni wrote:
> On 2014/03/01 04:49:31, gaochun wrote:
> > On 2014/02/28 08:07:18, dmazzoni wrote:
> > > lgtm
> > > 
> > > I'll start try jobs for you. Please look at any compile failures or test
> > > failures and make sure they're not related.
> > 
> > The patch did not cause any build issue and block any test.
> 
> Looks to me like it doesn't compile on Mac:
> 
> FAILED: clang++ -MMD -MF obj/chrome/browser/ui/browser_ui.browser.o.d
> -DV8_DEPRECATION_WARNINGS -DCHROMIUM_BUILD -DCOMPONENT_BUILD
> -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1
> -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY
> -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
> -DENABLE_NEW_GAMEPAD_API=1 -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY
> -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDCHECK_ALWAYS_ON=1
> -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
> -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1
> -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1
> -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2
> -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1
> -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
-DENABLE_SETTINGS_APP=1
> -DENABLE_MANAGED_USERS=1 -DNACL_WINDOWS=0 -DNACL_LINUX=0 -DNACL_OSX=1
> -DNACL_TARGET_SUBARCH=32 -DNACL_TARGET_ARCH=x86 -DNACL_BUILD_SUBARCH=32
> -DNACL_BUILD_ARCH=x86 -DFULL_SAFE_BROWSING -DGTEST_HAS_POSIX_RE=0
> -DLIBPEERCONNECTION_LIB=1 -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI
> -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DPASSWORD_MANAGER_ENABLE_SYNC
> -DNO_NSPR_10_SUPPORT -DNSS_ENABLE_ECC -DNSS_STATIC -DNSS_USE_STATIC_LIBS
> -DUSE_UTIL_DIRECTLY -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0
> -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1
> '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
> -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1
> -DSK_SUPPORT_LEGACY_LAYERRASTERIZER_API=1
-DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT
> -DSK_SUPPORT_LEGACY_COMPATIBLEDEVICE_CONFIG=1
> -DSK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS=1
-DSK_SUPPORT_LEGACY_COPYTO_CONFIG
> -DSK_SUPPORT_DEEPCOPYTO_CONFIG -DSK_USE_POSIX_THREADS
> -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DU_USING_ICU_NAMESPACE=0
-DLIBXML_STATIC
> -DXML_STATIC -DHUNSPELL_STATIC -DHUNSPELL_CHROME_CLIENT -DUSE_HUNSPELL
> -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH
> -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DOSX
-DPOSIX
> -DV8_SHARED -DUSING_V8_SHARED -DUSE_CUPS
> '-DCUSTOM_BASICTYPES="base/basictypes.h"'
> '-DCUSTOM_SCOPED_PTR="base/memory/scoped_ptr.h"' -D__STDC_CONSTANT_MACROS
> -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1
> -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -I../.. -Iobj/chrome/browser_ui.gen
> -Igen -I../../skia/config -I../../third_party/khronos -I../../gpu
> -I../../third_party/WebKit/Source -Igen/protoc_out
-I../../third_party/protobuf
> -I../../third_party/protobuf/src -Igen/chrome -Igen/components/strings
> -I../../third_party/nss/nspr/pr/include -I../../third_party/nss/nspr/lib/ds
> -I../../third_party/nss/nspr/lib/libc/include
> -I../../third_party/nss/nss/lib/base -I../../third_party/nss/nss/lib/certdb
> -I../../third_party/nss/nss/lib/certhigh
> -I../../third_party/nss/nss/lib/cryptohi -I../../third_party/nss/nss/lib/dev
> -I../../third_party/nss/nss/lib/freebl
> -I../../third_party/nss/nss/lib/freebl/ecl -I../../third_party/nss/nss/lib/nss
> -I../../third_party/nss/nss/lib/pk11wrap -I../../third_party/nss/nss/lib/pkcs7
> -I../../third_party/nss/nss/lib/pki -I../../third_party/nss/nss/lib/smime
> -I../../third_party/nss/nss/lib/softoken -I../../third_party/nss/nss/lib/util
> -I../../third_party/skia/src/core -I../../third_party/skia/include/core
> -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf
> -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy
> -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe
> -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
> -I../../skia/ext -I../../third_party/skia/include/utils/mac
> -I../../third_party/cacheinvalidation/overrides
> -I../../third_party/cacheinvalidation/src
> -I../../third_party/cacheinvalidation/google/cacheinvalidation
> -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common
> -I../../third_party/libusb/src/libusb -I../../third_party/libxml/mac/include
> -I../../third_party/libxml/src/include -I../../third_party/zlib
> -Igen/ui/app_locale_settings -Igen/ui/ui_strings -Igen/ui/ui_resources
> -I../../third_party/re2 -I../../third_party/expat/files/lib
> -I../../third_party/leveldatabase/src/include
> -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase
> -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source
> -I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc
> -I../../third_party/npapi -I../../third_party/npapi/bindings
-I../../v8/include
> -Igen/webkit -Igen/policy -I../../third_party/google_toolbox_for_mac
> -I../../third_party/google_toolbox_for_mac/src
> -I../../third_party/google_toolbox_for_mac/src/AppKit
> -I../../third_party/google_toolbox_for_mac/src/DebugUtils
> -I../../third_party/google_toolbox_for_mac/src/Foundation
> -I../../third_party/libaddressinput/chromium/cpp/include
> -Igen/third_party/libaddressinput/ -isysroot
>
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk
> -O0 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch
> i386 -Wall -Wendif-labels -Wextra -Wno-unused-parameter
> -Wno-missing-field-initializers -Wheader-hygiene -Wno-c++11-narrowing
> -Wno-char-subscripts -Wno-unneeded-internal-declaration
> -Wno-covered-switch-default -Wstring-conversion -Wno-deprecated-register
> -Wexit-time-destructors -std=gnu++11 -fno-rtti -fno-exceptions
> -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang
>
/Volumes/data/b/build/slave/mac/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
> -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics
> -fno-strict-aliasing -fstack-protector-all  -c
> ../../chrome/browser/ui/browser.cc -o
obj/chrome/browser/ui/browser_ui.browser.o
> In file included from ../../chrome/browser/ui/browser.cc:80:
>
../../chrome/browser/speech/extension_api/tts_engine_extension_api.h:37:3:error:
> [chromium-style] Overriding method must have "virtual" keyword.
>   void GetVoices(Profile* profile,
>   ^
>   virtual

The compile issue was fixed, please try build again, thanks.

[dmazzoni, 2014-03-03 04:18:22]

Thanks! Try jobs running now. If they look good I'll commit.

[dmazzoni, 2014-03-04 07:12:34]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-03-04 07:12:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chun.gao@intel.com/181123004/80001

[commit-bot: I haz the power, 2014-03-04 10:22:55]

Change committed as 254740

[merkulova, 2014-03-06 14:53:36]

A revert of this CL has been created in
https://codereview.chromium.org/188633003/ by merkulova@chromium.org.

The reason for reverting is: Breakes ChromeVox spoken feedback on OOBE..